fix: fix max_retries is hardcode

[fatelei]

Important

1. Make sure you have read our contribution guidelines
2. Ensure there is an associated issue and you have been assigned to it
3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #33571
fix #33592

Screenshots

Before	After
...	...

Checklist

• This change requires a documentation update, included: Dify Document
• I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
• I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
• I've updated the documentation accordingly.
• I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue by enhancing configuration flexibility for Redis connection pooling and making HTTP request retry behavior configurable. The changes ensure that environment variables for Redis maximum connections are parsed correctly, and HTTP requests can leverage a dynamic retry mechanism, improving the robustness of the system.

Highlights

• Redis Configuration: Implemented a Pydantic field validator for REDIS_MAX_CONNECTIONS to correctly interpret empty string values from environment variables as None, allowing the library's default to be used when explicitly unset.
• HTTP Request Retries: Modified the HTTP request node to use a configurable ssrf_default_max_retries value for max_retries instead of a hardcoded 0, providing more flexibility in handling transient network issues.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Pyrefly Diff

No changes detected.

[gemini-code-assist]

Code Review

This pull request makes two improvements. It allows REDIS_MAX_CONNECTIONS to be set as an empty environment variable, correctly interpreting it as unset. It also configures the HTTP request node to use a default number of retries instead of a hardcoded zero. My feedback points out a small redundancy in how the retry value is passed, suggesting a simplification.

[Copilot]

Pull request overview

This PR adjusts runtime configuration behavior in the API layer by (1) changing how the HTTP Request workflow node configures HTTP-layer retries and (2) improving Redis settings parsing to treat an empty env var as “unset”.

Changes:

• Update the HTTP Request node to pass a configurable default retry count into its HTTP executor.
• Add a Pydantic field_validator to allow REDIS_MAX_CONNECTIONS="" in env/.env to be interpreted as None.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
api/dify_graph/nodes/http_request/node.py	Changes the Executor construction to use a config-derived max_retries instead of hard-coding 0.
api/configs/middleware/cache/redis_config.py	Adds env parsing behavior so empty-string REDIS_MAX_CONNECTIONS becomes None (unset).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

Pyrefly Diff

No changes detected.