[8.x] Remove 204 response and instead be explicit with ignores#1187
Merged
taylorotwell merged 6 commits intolaravel:8.xfrom Feb 25, 2026
Merged
[8.x] Remove 204 response and instead be explicit with ignores#1187taylorotwell merged 6 commits intolaravel:8.xfrom
taylorotwell merged 6 commits intolaravel:8.xfrom
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ive had loaaads of flaky tests which made me deep dive this..
The login and logout routes were returning a 204 No Content response. This was originally added to suppress favicon.ico 404 errors appearing in the browser console log via #1061
However, the browser treats a 204 as a "no navigation" response, which means in fast CI it sees it and immediately continues without waiting for the session to be updated. This can cause a race condition see below of my access log:
Rather than do a 204 response which causes flakiness, I've just added a way to ignore specific messages, which ignores favicon issues from the browser log, and it also means users can tap into it too. The alternative is to just drop the response and let users worry about the log, but felt nice to add a way to tap into as its prevented atm
TLDR is this stops a huge amount of flaky tests
I've ran this with a local branch for the past few hours and had no flaky tests, where as usually we'd have to re-run the tests 2-5 times per time.