update the tutorial #809
update the tutorial #809
Conversation
|
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
| # with indices (3 is out) | ||
| pop[2015, 'BruCap', X.age.i[:3], 'F', 'BE'] | ||
| # with labels | ||
| year = pop.time.i[position] |
There was a problem hiding this comment.
this is unclear it uses labels. Use an explicit year instead?
|
|
||
| - code: | | ||
| # calculates 'pop[year+2] - pop[year]' | ||
| pop.diff('time', d=2) | ||
| # warning: divnot0 may return a float array while an integer is expected |
There was a problem hiding this comment.
in this regard, it should have the same behavior than pop / divisor, right? The warning as is would make a user think this is specific to divnot0. Maybe, you should move this warning and the astype solution to the arithmetic ops section.
There was a problem hiding this comment.
I am a bit ill at ease with the change for percent.
I am unsure which of:
self * 100.0 / self.sum(*axes)
(self / self.sum(*axes)) * 100
is the more precise (my gut feeling goes for the first version), but assuming the first is not worse than the second, I would pick the first solution so that our current users model results change as little as possible (I think that way, it will only change their results if it was wrong).
In either case, please merge this PR as is or with the alternative percent change without further review.
…values if the array contains integer values close to the highest integer value available
alixdamman
force-pushed
the
tutorial
branch
2 times, most recently
from
74db168 to
8531eb7
Compare
- added generate_data.py module to generate the example and test data - renamed 'population_session' dataset as 'demography_eurostat' - included values for years 2016 and 2017 for all arrays of 'demography_eurostat' - fix larray-project#785 - added the 'Pythonic VS String Syntax' section - updated all existing sections to include changes up to the 0.31 release version
No description provided.