Skip to content

Fix import errors when user_paths.py does not exist#74

Open
JadenStrom wants to merge 3 commits intolasp:masterfrom
JadenStrom:newUpdates
Open

Fix import errors when user_paths.py does not exist#74
JadenStrom wants to merge 3 commits intolasp:masterfrom
JadenStrom:newUpdates

Conversation

@JadenStrom
Copy link

@JadenStrom JadenStrom commented Jun 2, 2025

Pull Request Checklist

  • Code Follows PEP8 guidelines (explain any exceptions)
  • New routines don't duplicate existing functionality
  • Original authors of modified routines have been added as reviewers

This addresses issue #71

@planetarymike planetarymike changed the title First commit for user_paths.py errors Fix import errors when user_paths.py does not exist Jun 3, 2025
@planetarymike
Copy link
Collaborator

Hi @JadenStrom,

Thanks for submitting this--- I modified the PR title so that it's more descriptive. A few things:

  • You don't need to put "first commit" in every commit on a new issue; it's better to describe the change as tersely as possible.
  • Your branch name should be more descriptive than "newUpdates"; think about whether a stranger would be able to tell what changes the branch was intended to implement from the name alone.
  • Commits on thematically unrelated issues need to be submitted to different PRs, so please remove the commits unrelated to the user_paths.py issue and put those in separate branches / PRs.
  • You should check the conditions for the checkboxes in the original PR prompt and check the boxes if those conditions are met, or explain any exceptions.

@JadenStrom
Copy link
Author

JadenStrom commented Jun 3, 2025 via email

@planetarymike
Copy link
Collaborator

Yeah, you'll need to create separate branches for each PR. One change, one branch.

@JadenStrom
Copy link
Author

JadenStrom commented Jun 3, 2025 via email

@JadenStrom
Copy link
Author

JadenStrom commented Jun 3, 2025 via email

@planetarymike
Copy link
Collaborator

You should be able to modify your IDE to automatically warn you about any PEP8 violations, otherwise don't worry about it too much.

@JadenStrom
Copy link
Author

JadenStrom commented Jun 3, 2025 via email

@emcangi
Copy link
Collaborator

emcangi commented Jun 3, 2025

@JadenStrom keywords to look for are flake8 and pylint, common tools to keep track of the PEP8 stuff for you, but don't worry too much because I think the whole codebase needs to be updated to be compliant because there's lots of little issues. Good if you can write it in a compliant way from start though. I am using VSCode for Python and it has a plugin for Pylint.

@JadenStrom
Copy link
Author

JadenStrom commented Jun 3, 2025 via email

@emcangi
Copy link
Collaborator

emcangi commented Jun 3, 2025

Pycharm should have Pylint available: https://plugins.jetbrains.com/plugin/11084-pylint

I forgot to clarify that these are tools for "linting" which is the process of making sure that things are tidy and correct (https://en.wikipedia.org/wiki/Lint_%28software%29)

its easiest to get started with linting right away since it keeps code readable. you will get warnings about line lengths but those I think are fine to ignore for now since the whole codebase has lots of lines that are too long. Anything else though is good to keep track of.

@JadenStrom
Copy link
Author

JadenStrom commented Jun 4, 2025 via email

@JadenStrom JadenStrom mentioned this pull request Jun 9, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants