Fix import errors when user_paths.py does not exist#74
Fix import errors when user_paths.py does not exist#74JadenStrom wants to merge 3 commits intolasp:masterfrom
Conversation
|
Hi @JadenStrom, Thanks for submitting this--- I modified the PR title so that it's more descriptive. A few things:
|
|
Hello Mike,
Thanks for the explanations, I will take all of those things into consideration and make sure to apply them in the future. For the commits being in separate PRs, does that mean I'll need to create separate branches for each? Unless there is a way to create multiple PR's from the same branch?
…________________________________
From: Mike Chaffin ***@***.***>
Sent: Tuesday, June 3, 2025 12:20 PM
To: lasp/maven_iuvs ***@***.***>
Cc: Jaden Strommer ***@***.***>; Mention ***@***.***>
Subject: Re: [lasp/maven_iuvs] Fix import errors when user_paths.py does not exist (PR #74)
[External email - use caution]
[https://avatars.githubusercontent.com/u/13734186?s=20&v=4]planetarymike left a comment (lasp/maven_iuvs#74)<#74 (comment)>
Hi @JadenStrom<https://github.com/JadenStrom>,
Thanks for submitting this--- I modified the PR title so that it's more descriptive. A few things:
* You don't need to put "first commit" in every commit on a new issue; it's better to describe the change as tersely as possible.
* Your branch name should be more descriptive than "newUpdates"; think about whether a stranger would be able to tell what changes the branch was intended to implement from the name alone.
* Commits on thematically unrelated issues need to be submitted to different PRs, so please remove the commits unrelated to the user_paths.py issue and put those in separate branches / PRs.
* You should check the conditions for the checkboxes in the original PR prompt and check the boxes if those conditions are met, or explain any exceptions.
—
Reply to this email directly, view it on GitHub<#74 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BGK5ISCVEZJ3VXVYJVF3S4L3BXRPRAVCNFSM6AAAAAB6ODWLZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMZWGYYTCMBYGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Yeah, you'll need to create separate branches for each PR. One change, one branch. |
|
Alright, I will get on that. Thanks so much,
Jaden
…________________________________
From: Mike Chaffin ***@***.***>
Sent: Tuesday, June 3, 2025 12:54 PM
To: lasp/maven_iuvs ***@***.***>
Cc: Jaden Strommer ***@***.***>; Mention ***@***.***>
Subject: Re: [lasp/maven_iuvs] Fix import errors when user_paths.py does not exist (PR #74)
[External email - use caution]
[https://avatars.githubusercontent.com/u/13734186?s=20&v=4]planetarymike left a comment (lasp/maven_iuvs#74)<#74 (comment)>
Yeah, you'll need to create separate branches for each PR. One change, one branch.
—
Reply to this email directly, view it on GitHub<#74 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BGK5ISAO7ASA5LAQA3DTGSL3BXVMZAVCNFSM6AAAAAB6ODWLZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMZWG42DAMZVGU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Also, I am not sure what the PEP8 guidelines are, where can I find them so I can check and make sure it all lines up?
…________________________________
From: Mike Chaffin ***@***.***>
Sent: Tuesday, June 3, 2025 12:54 PM
To: lasp/maven_iuvs ***@***.***>
Cc: Jaden Strommer ***@***.***>; Mention ***@***.***>
Subject: Re: [lasp/maven_iuvs] Fix import errors when user_paths.py does not exist (PR #74)
[External email - use caution]
[https://avatars.githubusercontent.com/u/13734186?s=20&v=4]planetarymike left a comment (lasp/maven_iuvs#74)<#74 (comment)>
Yeah, you'll need to create separate branches for each PR. One change, one branch.
—
Reply to this email directly, view it on GitHub<#74 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BGK5ISAO7ASA5LAQA3DTGSL3BXVMZAVCNFSM6AAAAAB6ODWLZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMZWG42DAMZVGU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
You should be able to modify your IDE to automatically warn you about any PEP8 violations, otherwise don't worry about it too much. |
|
Alright, sounds good. Thank you.
…________________________________
From: Mike Chaffin ***@***.***>
Sent: Tuesday, June 3, 2025 2:05 PM
To: lasp/maven_iuvs ***@***.***>
Cc: Jaden Strommer ***@***.***>; Mention ***@***.***>
Subject: Re: [lasp/maven_iuvs] Fix import errors when user_paths.py does not exist (PR #74)
[External email - use caution]
[https://avatars.githubusercontent.com/u/13734186?s=20&v=4]planetarymike left a comment (lasp/maven_iuvs#74)<#74 (comment)>
You should be able to modify your IDE to automatically warn you about any PEP8 violations, otherwise don't worry about it too much.
—
Reply to this email directly, view it on GitHub<#74 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BGK5ISAMKOM7UO7WYFZEHFD3BX5XVAVCNFSM6AAAAAB6ODWLZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMZWHE4TONJTG4>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@JadenStrom keywords to look for are flake8 and pylint, common tools to keep track of the PEP8 stuff for you, but don't worry too much because I think the whole codebase needs to be updated to be compliant because there's lots of little issues. Good if you can write it in a compliant way from start though. I am using VSCode for Python and it has a plugin for Pylint. |
|
Okay, I can look into the PyCharm features and see if there is any mention of those words. If not, I can just disregard it for the time being if that's alright? Or should I try to find some other workarounds to find them?
…________________________________
From: Eryn Cangi ***@***.***>
Sent: Tuesday, June 3, 2025 2:25 PM
To: lasp/maven_iuvs ***@***.***>
Cc: Jaden Strommer ***@***.***>; Mention ***@***.***>
Subject: Re: [lasp/maven_iuvs] Fix import errors when user_paths.py does not exist (PR #74)
[External email - use caution]
[https://avatars.githubusercontent.com/u/4439854?s=20&v=4]emcangi left a comment (lasp/maven_iuvs#74)<#74 (comment)>
@JadenStrom<https://github.com/JadenStrom> keywords to look for are flake8 and pylint, common tools to keep track of the PEP8 stuff for you, but don't worry too much because I think the whole codebase needs to be updated to be compliant because there's lots of little issues. Good if you can write it in a compliant way from start though. I am using VSCode for Python and it has a plugin for Pylint.
—
Reply to this email directly, view it on GitHub<#74 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BGK5ISCNWXDR2BGE3MOQNZL3BYADXAVCNFSM6AAAAAB6ODWLZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMZXGA4DANBVHE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Pycharm should have Pylint available: https://plugins.jetbrains.com/plugin/11084-pylint I forgot to clarify that these are tools for "linting" which is the process of making sure that things are tidy and correct (https://en.wikipedia.org/wiki/Lint_%28software%29) its easiest to get started with linting right away since it keeps code readable. you will get warnings about line lengths but those I think are fine to ignore for now since the whole codebase has lots of lines that are too long. Anything else though is good to keep track of. |
|
Alright, I will make sure to use the Pylint on PyCharm going forward.
Thanks,
Jaden
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Eryn Cangi ***@***.***>
Sent: Tuesday, June 3, 2025 5:45:40 PM
To: lasp/maven_iuvs ***@***.***>
Cc: Jaden Strommer ***@***.***>; Mention ***@***.***>
Subject: Re: [lasp/maven_iuvs] Fix import errors when user_paths.py does not exist (PR #74)
[External email - use caution]
[https://avatars.githubusercontent.com/u/4439854?s=20&v=4]emcangi left a comment (lasp/maven_iuvs#74)<#74 (comment)>
Pycharm should have Pylint available: https://plugins.jetbrains.com/plugin/11084-pylint
I forgot to clarify that these are tools for "linting" which is the process of making sure that things are tidy and correct (https://en.wikipedia.org/wiki/Lint_%28software%29)
its easiest to get started with linting right away since it keeps code readable. you will get warnings about line lengths but those I think are fine to ignore for now since the whole codebase has lots of lines that are too long. Anything else though is good to keep track of.
—
Reply to this email directly, view it on GitHub<#74 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BGK5ISEXPBMNYHN4LYVS3ZT3BYXSJAVCNFSM6AAAAAB6ODWLZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMZXG42DSNZQG4>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Pull Request Checklist
This addresses issue #71