chore: [REL-4161] move tag creation above goreleaser #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
launchdarkly-upra
bot
changed the title
blaqbern
changed the title
sloloris
approved these changes
Jul 28, 2025
blaqbern
deleted the
cblackburn/REL-4161/move-tag-creation-ahead-of-goreleaser
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought goreleaser would pull the version from
internal/version/version.go, and so I though updating that with the new version and committing the change would suffice, but turns out (at least, I think) goreleaser is actually pulling the latest tag that matches a version regexp. So this update creates the tag as well before running goreleaser.Related Jira issue: REL-4161: Migrate ld-find-code-refs from Releaser to GHA