Skip to content

chore: [REL-4161] move tag creation above goreleaser #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blaqbern merged 1 commit into from
Jul 28, 2025
Merged

chore: [REL-4161] move tag creation above goreleaser #536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ jobs:
run: |
git show -p
ls -1a "$ARTIFACT_DIRECTORY"
- name: create tag
run: ./scripts/release/create-tag.sh
- name: push to origin
run: ./scripts/release/push-to-origin.sh
- name: create Github release
uses: ncipollo/[email protected]
if: ${{ !inputs.dryRun }}
Expand Down
3 changes: 3 additions & 0 deletions scripts/release/prepare-release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,16 @@ update_changelog() (
sed -i "4r /dev/stdin" CHANGELOG.md <<< "$changelog_entry"$'\n'
)

# update metadata files and CHANGELOG
update_go
update_orb
update_gha
update_bitbucket
update_changelog

# commit changes and create tag
git config user.name "LaunchDarklyReleaseBot"
git config user.email "[email protected]"
git add .
git commit -m "Prepare release ${release_tag}"
git tag "${release_tag}"
10 changes: 5 additions & 5 deletions scripts/release/create-tag.sh → scripts/release/push-to-origin.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,21 +9,21 @@ tag_exists() (
git rev-parse "${release_tag}" >/dev/null 2>&1
)

create_tag() (
push_to_origin() (
if tag_exists; then
echo "Tag $release_tag already exists. Aborting."
exit 1
fi

git tag "${release_tag}"
git push origin HEAD
git push origin "${release_tag}"
)

if [[ "$DRY_RUN" == "true" ]]; then
git reset --hard HEAD^
echo "Dry run mode: skipping tag and push"
git tag -d "$release_tag" # defensive
git reset --hard HEAD^ # defensive
echo "Dry run mode: skipping push"
else
create_tag
push_to_origin
fi

Loading