chore: Update log test scenarios. #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I am going to have to update the test suites. These type safe languages don't allow for the missing severity. |
kinyoklion
commented
Oct 6, 2025
sdk/@launchdarkly/observability-dotnet/src/LaunchDarkly.Observability/Otel/CommonOtelOptions.cs
Show resolved
Hide resolved
kinyoklion
commented
Oct 6, 2025
...aunchdarkly/observability-dotnet/test/LaunchDarkly.Observability.Tests/CustomSamplerTests.cs
Show resolved
Hide resolved
kinyoklion
commented
Oct 6, 2025
sdk/@launchdarkly/observability-python/ldobserve/_otel/_sampling/test_custom_sampler.py
Show resolved
Hide resolved
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Vadman97
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extending log tests suite.
Note
Adds new log sampling scenarios requiring both message and severity, updates .NET test severity fallback to Information, and makes Python tests tolerate missing expected attributes.
messageandseverityText(empty log, message-only, severity-only) in.../observability-dotnet/.../log-test-scenarios.jsonand.../observability-python/.../log-test-scenarios.json.SeverityTextToLogLeveldefault now returnsInformationinstead of throwing for unsupportedseverityTextinCustomSamplerTests.cs.test_custom_sampler.py, only assertresult.attributeswhen"attributes"exists inexpected_resultand is non-null for both span and log scenarios.Written by Cursor Bugbot for commit 5e991a0. This will update automatically on new commits. Configure here.