Skip to content

chore: Update log test scenarios. #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kinyoklion merged 4 commits into from
Oct 7, 2025
Merged

chore: Update log test scenarios. #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
22dea3b
chore: Update log test scenarios.
kinyoklion Oct 3, 2025
1201522
Merge branch 'main' into rlamb/update-log-test-scenarios
kinyoklion Oct 6, 2025
ffaec24
Handle missing log level in .Net.
kinyoklion Oct 6, 2025
5e991a0
Check if attributes exists before checking if it is none.
kinyoklion Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ...aunchdarkly/observability-dotnet/src/LaunchDarkly.Observability/Otel/CommonOtelOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,8 @@
using System.Threading.Tasks;
using LaunchDarkly.Observability.Logging;
using LaunchDarkly.Observability.Sampling;
using LaunchDarkly.Sdk.Internal.Concurrent;
using OpenTelemetry;
using OpenTelemetry.Exporter;
using OpenTelemetry.Logs;
using OpenTelemetry.Metrics;
using OpenTelemetry.Resources;
using OpenTelemetry.Trace;
Expand Down
6 changes: 4 additions & 2 deletions ...chdarkly/observability-dotnet/test/LaunchDarkly.Observability.Tests/CustomSamplerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,8 +241,10 @@ private LogLevel SeverityTextToLogLevel(string severityText)
case null:
return LogLevel.Information;
default:
// Unsupported in this test suite.
throw new ArgumentOutOfRangeException(nameof(severityText), severityText, null);
// Log records cannot be made without a level, but in some languages they can, so we
// use "Information" for a missing level in the test suite.
// We cannot use "None" because the open telemetry logger is hard-coded to discard "None".
return LogLevel.Information;
}
}

Expand Down
97 changes: 97 additions & 0 deletions ...darkly/observability-dotnet/test/LaunchDarkly.Observability.Tests/log-test-scenarios.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,5 +388,102 @@
}
}
]
},
{
"description": "Should not match an empty log when message and severity are defined",
"samplingConfig": {
"logs": [
{
"message": {
"regexValue": "Database connection .*"
},
"severityText": {
"matchValue": "error"
},
"samplingRatio": 90
}
]
},
"inputLog": {},
"samplerFunctionCases": [
{
"type": "always",
"expected_result": {
"sample": true
}
},
{
"type": "never",
"expected_result": {
"sample": true
}
}
]
},
{
"description": "Should not match a log with a message when message and severity are defined",
"samplingConfig": {
"logs": [
{
"message": {
"regexValue": "Database connection .*"
},
"severityText": {
"matchValue": "error"
},
"samplingRatio": 90
}
]
},
"inputLog": {
"message": "Database connection failed: timeout"
},
"samplerFunctionCases": [
{
"type": "always",
"expected_result": {
"sample": true
}
},
{
"type": "never",
"expected_result": {
"sample": true
}
}
]
},
{
"description": "Should not match a log with only severity when message and severity are defined",
"samplingConfig": {
"logs": [
{
"message": {
"regexValue": "Database connection .*"
},
"severityText": {
"matchValue": "error"
},
"samplingRatio": 90
}
]
},
"inputLog": {
"severityText": "error"
},
"samplerFunctionCases": [
{
"type": "always",
"expected_result": {
"sample": true
}
},
{
"type": "never",
"expected_result": {
"sample": true
}
}
]
}
]
97 changes: 97 additions & 0 deletions sdk/@launchdarkly/observability-python/ldobserve/_otel/_sampling/log-test-scenarios.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,5 +388,102 @@
}
}
]
},
{
"description": "Should not match an empty log when message and severity are defined",
"samplingConfig": {
"logs": [
{
"message": {
"regexValue": "Database connection .*"
},
"severityText": {
"matchValue": "error"
},
"samplingRatio": 90
}
]
},
"inputLog": {},
"samplerFunctionCases": [
{
"type": "always",
"expected_result": {
"sample": true
}
},
{
"type": "never",
"expected_result": {
"sample": true
}
}
]
},
{
"description": "Should not match a log with a message when message and severity are defined",
"samplingConfig": {
"logs": [
{
"message": {
"regexValue": "Database connection .*"
},
"severityText": {
"matchValue": "error"
},
"samplingRatio": 90
}
]
},
"inputLog": {
"message": "Database connection failed: timeout"
},
"samplerFunctionCases": [
{
"type": "always",
"expected_result": {
"sample": true
}
},
{
"type": "never",
"expected_result": {
"sample": true
}
}
]
},
{
"description": "Should not match a log with only severity when message and severity are defined",
"samplingConfig": {
"logs": [
{
"message": {
"regexValue": "Database connection .*"
},
"severityText": {
"matchValue": "error"
},
"samplingRatio": 90
}
]
},
"inputLog": {
"severityText": "error"
},
"samplerFunctionCases": [
{
"type": "always",
"expected_result": {
"sample": true
}
},
{
"type": "never",
"expected_result": {
"sample": true
}
}
]
}
]
4 changes: 2 additions & 2 deletions sdk/@launchdarkly/observability-python/ldobserve/_otel/_sampling/test_custom_sampler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ def run_span_scenarios():
assert sampler.is_sampling_enabled() is True
result = sampler.sample_span(span)
assert result.sample == expected["sample"], desc
if expected["attributes"] is not None:
if "attributes" in expected and expected["attributes"] is not None:
assert result.attributes == expected["attributes"], desc
else:
assert result.attributes is None or result.attributes == {}, desc
Expand All @@ -202,7 +202,7 @@ def run_log_scenarios():
assert sampler.is_sampling_enabled() is True
result = sampler.sample_log(log)
assert result.sample == expected["sample"], desc
if expected["attributes"] is not None:
if "attributes" in expected and expected["attributes"] is not None:
assert result.attributes == expected["attributes"], desc
else:
assert result.attributes is None or result.attributes == {}, desc
Expand Down
Loading