feat: O11Y-677 - Add session.id to all metrics #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that all custom metrics recorded by the Android observability SDK include the `session.id` attribute. It won't work for OTEL instrumentations like io.opentelemetry.okhttp-3.0.
tanderson-ld
approved these changes
Oct 30, 2025
Merged
tanderson-ld
pushed a commit
that referenced
this pull request
Oct 31, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-observability-android: 0.13.0</summary> ## [0.13.0](launchdarkly-observability-android-0.12.0...launchdarkly-observability-android-0.13.0) (2025-10-31) ### Features * Android observability session replay masking support ([#276](#276)) ([c34670b](c34670b)) * O11Y-677 - Add session.id to all metrics ([#279](#279)) ([1927107](1927107)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Release Android observability SDK 0.13.0 with session replay masking and session.id on all metrics, updating manifest and gradle version. > > - **Release: Android observability SDK `sdk/@launchdarkly/observability-android` v0.13.0** > - Adds session replay masking support. > - Adds `session.id` to all metrics. > - **Version updates**: > - `.release-please-manifest.json` and `sdk/@launchdarkly/observability-android/gradle.properties` set to `0.13.0`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 238bdbd. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change ensures that all custom metrics recorded by the Android observability SDK include the
session.idattribute.For logs and spans the
session.idis automatically added by OTEL.Are there any deployment considerations?
This won't work for OTEL instrumentations like
io.opentelemetry.okhttp-3.0that automatically record metrics behind the scenes without using our record methods. That edge case will be tackled in https://launchdarkly.atlassian.net/browse/O11Y-711Note
Appends
session.idto attributes for all recorded metrics via a newAttributes.addSessionId()helper.session.idto attributes inrecordMetric,recordCount,recordIncr,recordHistogram, andrecordUpDownCounterby usingmetric.attributes.addSessionId()inInstrumentationManager.kt.Attributes.addSessionId()helper andSESSION_ID_ATTRIBUTE = "session.id"constant.Written by Cursor Bugbot for commit 3b48286. This will update automatically on new commits. Configure here.