Skip to content

feat: O11Y-677 - Add session.id to all metrics #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agrognetti merged 1 commit into from
Oct 30, 2025
Merged

feat: O11Y-677 - Add session.id to all metrics #279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions ...droid/lib/src/main/kotlin/com/launchdarkly/observability/client/InstrumentationManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,37 +277,37 @@ class InstrumentationManager(
val gauge = gaugeCache.getOrPut(metric.name) {
otelMeter.gaugeBuilder(metric.name).build()
}
gauge.set(metric.value, metric.attributes)
gauge.set(metric.value, metric.attributes.addSessionId())
}

fun recordCount(metric: Metric) {
// TODO: handle double casting to long better
val counter = counterCache.getOrPut(metric.name) {
otelMeter.counterBuilder(metric.name).build()
}
counter.add(metric.value.toLong(), metric.attributes)
counter.add(metric.value.toLong(), metric.attributes.addSessionId())
}

fun recordIncr(metric: Metric) {
val counter = counterCache.getOrPut(metric.name) {
otelMeter.counterBuilder(metric.name).build()
}
// It increments the value until the metric is exported, then it’s reset.
counter.add(1, metric.attributes)
counter.add(1, metric.attributes.addSessionId())
}

fun recordHistogram(metric: Metric) {
val histogram = histogramCache.getOrPut(metric.name) {
otelMeter.histogramBuilder(metric.name).build()
}
histogram.record(metric.value, metric.attributes)
histogram.record(metric.value, metric.attributes.addSessionId())
}

fun recordUpDownCounter(metric: Metric) {
val upDownCounter = upDownCounterCache.getOrPut(metric.name) {
otelMeter.upDownCounterBuilder(metric.name).build()
}
upDownCounter.add(metric.value.toLong(), metric.attributes)
upDownCounter.add(metric.value.toLong(), metric.attributes.addSessionId())
}

fun recordLog(message: String, severity: Severity, attributes: Attributes) {
Expand Down Expand Up @@ -385,12 +385,15 @@ class InstrumentationManager(
}
}

private fun Attributes.addSessionId() = this.toBuilder().put(SESSION_ID_ATTRIBUTE, otelRUM.rumSessionId).build()

companion object {
private const val METRICS_PATH = "/v1/metrics"
private const val LOGS_PATH = "/v1/logs"
private const val TRACES_PATH = "/v1/traces"
private const val INSTRUMENTATION_SCOPE_NAME = "com.launchdarkly.observability"
const val ERROR_SPAN_NAME = "highlight.error"
const val SESSION_ID_ATTRIBUTE = "session.id"
private const val BATCH_MAX_QUEUE_SIZE = 100
private const val BATCH_SCHEDULE_DELAY_MS = 1000L
private const val BATCH_EXPORTER_TIMEOUT_MS = 5000L
Expand Down
Loading