Skip to content

WIP #453

Open
abelonogov-ld wants to merge 16 commits intomainfrom
andrey/match-attributes
Open

WIP #453
abelonogov-ld wants to merge 16 commits intomainfrom
andrey/match-attributes

Conversation

@abelonogov-ld
Copy link
Copy Markdown
Contributor

@abelonogov-ld abelonogov-ld commented Mar 31, 2026

Summary

How did you test this change?

Are there any deployment considerations?


Note

Medium Risk
Changes how the native Android bridge sets serviceVersion and injects a new version attribute, which can affect telemetry identity and downstream correlation. Also updates sample/e2e instrumentation behavior but with limited functional surface area.

Overview
Aligns version reporting across the .NET/Android observability bridge by using the caller-provided serviceVersion in ObservabilityBridge and tagging telemetry with a maui-observability-version resource attribute during LDNative.Start.

Updates sample/e2e apps to emit additional telemetry during nested spans (records a counter + log) and tweaks Android e2e resourceAttributes to a more descriptive key/value. Bumps the LaunchDarkly.SessionReplay package version to 0.6.0.

Written by Cursor Bugbot for commit 73c0e2d. This will update automatically on new commits. Configure here.

* main:
  chore: release main (#447)
  fix: move Otel testing library out production runtime (#446)
- Adjusted the exclusion rules for OpenTelemetry JARs in LDObservability.Fat.csproj to ensure the main autoconfigure JAR is excluded while re-including the autoconfigure-spi JAR.
- Added a note in build.gradle.kts to clarify the filtering of OpenTelemetry JARs for NuGet packaging.
…i-projects

* andrey/open-telemetry-testing:
  refactor: update OpenTelemetry JAR handling in project files
  chore: release main (#450)
  feat!: Support clicks and custom event tracing (#432)

# Conflicts:
#	sdk/@launchdarkly/mobile-dotnet/observability/LDObservability.Fat.csproj
…utes

* andrey/simpligy-maui-projects:
  doesn't account version
  refactor: update OpenTelemetry JAR handling in project files
  chore: release main (#450)
  simplify maui projects to do not have repetitions
  minus 3 dependency
  address feedback
  revert incubator
  Refactor opentelemetry testing
  Remove instrumentation manager
  renaming to ObservabilityService to match Swift

# Conflicts:
#	sdk/@launchdarkly/mobile-dotnet/observability/Directory.Build.props
@abelonogov-ld abelonogov-ld requested a review from a team as a code owner March 31, 2026 23:46
* main:
  chore: simplify maui project by removing dependency repetitions (#451)
  fix: Remove 3 dependencies from MAUI Android (3 aar files) (#449)

# Conflicts:
#	sdk/@launchdarkly/mobile-dotnet/android/native/LDObserve/build.gradle.kts
#	sdk/@launchdarkly/mobile-dotnet/observability/Directory.Build.props
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

enabled = observability.isEnabled,
serviceName = observability.serviceName,
serviceVersion = observabilityVersion,
serviceVersion = observability.serviceVersion,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS and Android service version sources now diverge

High Severity

The Android bridge now uses observability.serviceVersion (the user-configured value, defaulting to "0.1.0") whereas the iOS bridge in SRClient.iOS.cs still sets ServiceVersion = observabilityVersion (the SDK assembly version). This means the two platforms will report different serviceVersion values for the same user configuration, breaking cross-platform consistency for telemetry data.

Additional Locations (1)
Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants