-
Notifications
You must be signed in to change notification settings - Fork 4
WIP #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
abelonogov-ld
wants to merge
16
commits into
main
Choose a base branch
from
andrey/match-attributes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
WIP #453
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
3098277
renaming to ObservabilityService to match Swift
abelonogov-ld ecb214e
Remove instrumentation manager
abelonogov-ld b34ffb8
Refactor opentelemetry testing
abelonogov-ld 4264286
revert incubator
abelonogov-ld 2941a91
address feedback
abelonogov-ld b77c4ca
minus 3 dependency
abelonogov-ld bbc5f43
Merge branch 'main' into andrey/open-telemetry-testing
abelonogov-ld bf0a4c1
simplify maui projects to do not have repetitions
abelonogov-ld 996cdda
pass maui version as "maui-observability-version"
abelonogov-ld 0a22270
nicier way to get maui version
abelonogov-ld 54fb3b3
Merge branch 'main' into andrey/open-telemetry-testing
abelonogov-ld f1e1ff3
refactor: update OpenTelemetry JAR handling in project files
abelonogov-ld 53b04cb
Merge branch 'andrey/open-telemetry-testing' into andrey/simpligy-mau…
abelonogov-ld fb0458e
doesn't account version
abelonogov-ld 2803207
Merge branch 'andrey/simpligy-maui-projects' into andrey/match-attrib…
abelonogov-ld 73c0e2d
Merge branch 'main' into andrey/match-attributes
abelonogov-ld File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
sdk/@launchdarkly/mobile-dotnet/observability/Directory.Build.props
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iOS and Android service version sources now diverge
High Severity
The Android bridge now uses
observability.serviceVersion(the user-configured value, defaulting to"0.1.0") whereas the iOS bridge inSRClient.iOS.csstill setsServiceVersion = observabilityVersion(the SDK assembly version). This means the two platforms will report differentserviceVersionvalues for the same user configuration, breaking cross-platform consistency for telemetry data.Additional Locations (1)
sdk/@launchdarkly/mobile-dotnet/observability/bridge/LDNative.cs#L48-L53