Skip to content

Fix: Remove unnecessary whitespace in Advanced Istio page #6688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −6
Open

Fix: Remove unnecessary whitespace in Advanced Istio page #6688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6441954
Reduced Spaces
Rajesh-Nagarajan-11 Aug 9, 2025
9d58e82
Merge branch 'master' into fix/whitespace-advanced-istio-page
vr-varad Aug 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Animated-steps-list/Steps-list/StepsList.style.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export const StepsListWrapper = styled.div`

& > li {
&:not(:last-of-type) {
margin-bottom: 600px;
margin-bottom: 150px;

@media (max-width: 850px) {
margin-bottom: 88px;
Expand Down
4 changes: 2 additions & 2 deletions src/components/Animated-steps-list/hero/hero.style.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ export const HeroWrapper = styled.div`
font-weight: 600;
}

padding: 12rem 0 20rem 0;
padding: 4rem 0 4rem 0;

@media (max-width: 800px) {
padding: 2rem 0 10rem 0;
padding: 1rem 0 2rem 0;
}

.content {
Expand Down
6 changes: 3 additions & 3 deletions src/components/Animated-steps-list/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ import FramedTerminal from "../Animated-terminal/Framed-terminal";
import { AnimatedStepsListWrapper } from "./AnimatedStepsList.style";

// The breakpoints where the next step of each animation triggers
const breakpoints = [0, 350, 1400, 2450, 2680];
const breakpoints = [0, 300, 800, 1300, 1700];

// The number of pixels before the next breakpoint that the animation should complete
const animationBottomPadding = [0, 620, 575, -50];
const animationBottomPadding = [0, 180, 180, 50];

const calculateCurrentFrame = (terminalSteps, currentIndex, scrollPosition) => {
const percentage = Math.min(
Expand All @@ -37,7 +37,7 @@ const AnimatedStepsList = ({ terminalHeroState, steps }) => {
const scrollPosition = useScrollPosition();
const [indicatorIndex, setIndicatorIndex] = useState(0);
const activeTerminalStateIndex =
scrollPosition <= 350 ? 0 : indicatorIndex + 1;
scrollPosition <= 300 ? 0 : indicatorIndex + 1;
const terminalSteps = [terminalHeroState].concat(
steps.map((step) => step.terminal)
);
Expand Down