-
Notifications
You must be signed in to change notification settings - Fork 40
Variable Stiffness Controller #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
danielsanjosepro
merged 9 commits into
learnsyslab:main
from
KAIST-IRiS-Haptics-Telerobotics:feature/variable-stiffness-impedance
Apr 2, 2026
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f300c84
feat: add runtime variable stiffness support via ROS2 topic
domrachev03 b755ac6
fix: adapt to ROS2 Jazzy
domrachev03 890289a
feat: add INFO logging for variable stiffness debugging
domrachev03 449ed00
fix: always create variable stiffness subscriber regardless of enable…
domrachev03 e8434d3
fix: bound stiffness values
domrachev03 c412d60
Revert "fix: adapt to ROS2 Jazzy"
domrachev03 fbe3107
fix: remove extra debug prints
domrachev03 ac78f83
fix: debug update stiffness
domrachev03 f08923b
refactor: add throttling to ROS2 loggers & rename max_stiffness -> va…
domrachev03 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -313,6 +313,30 @@ cartesian_controller: | |
| default_value: [ 0.039533, 0.025882, -0.04607, 0.036194, 0.026226, -0.021047, 0.0035526] | ||
| description: "Friction parameters part 3" | ||
|
|
||
| max_stiffness: | ||
| translational: | ||
| type: double | ||
| default_value: 900.0 | ||
| description: "Maximum allowed translational stiffness value. Stiffness values above this will be clamped." | ||
| validation: | ||
| bounds<>: [0.0, 5000.0] | ||
| rotational: | ||
| type: double | ||
| default_value: 60.0 | ||
| description: "Maximum allowed rotational stiffness value. Stiffness values above this will be clamped." | ||
| validation: | ||
| bounds<>: [0.0, 100.0] | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file already defines stiffness bounds (see a few lines above). The bounds here are below what we defined above. Probably it makes sense to call this variable_max_stiffness or something similar to not confuse it with the other one |
||
|
|
||
| variable_stiffness: | ||
| enabled: | ||
| type: bool | ||
| default_value: false | ||
| description: "Enable receiving stiffness updates via a ROS2 topic. When enabled, stiffness values from the topic override parameter-based stiffness." | ||
| topic: | ||
| type: string | ||
| default_value: "target_stiffness" | ||
| description: "Topic name for receiving variable stiffness updates (std_msgs/Float64MultiArray with 6 elements: [k_pos_x, k_pos_y, k_pos_z, k_rot_x, k_rot_y, k_rot_z])" | ||
|
|
||
| enable_introspection: | ||
| type: bool | ||
| default_value: false | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will spam messages if we are constantly changing stiffness, consider removing this or throttle it. Alternatively add a param to trigger logging