Skip to content

Bug fixes#141

Closed
iguinn wants to merge 40 commits intolegend-exp:mainfrom
iguinn:main
Closed

Bug fixes#141
iguinn wants to merge 40 commits intolegend-exp:mainfrom
iguinn:main

Conversation

@iguinn
Copy link
Copy Markdown
Contributor

@iguinn iguinn commented Apr 18, 2025

  • WaveformTable was managing its ndas itself in certain cases, which created refcheck errors
  • WaveformTable.set_wflen required a way to reshape the inner dimensions of arrays, so resize was modified to take collections.

iguinn and others added 30 commits October 11, 2024 13:30
@iguinn
Copy link
Copy Markdown
Contributor Author

iguinn commented Apr 18, 2025

Github is being strange for me, I think because of the squash merge, and wants to reapply a lot of previous commits to this. I tried moving this work to start at upstream/main, but it doesn't seem to want to update my main on github

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.17%. Comparing base (794f5a7) to head (e50b355).
Report is 41 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
+ Coverage   78.98%   79.17%   +0.19%     
==========================================
  Files          47       47              
  Lines        3535     3535              
==========================================
+ Hits         2792     2799       +7     
+ Misses        743      736       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ggmarshall
Copy link
Copy Markdown
Contributor

Superseded by #142

@ggmarshall ggmarshall closed this Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants