Closed
Conversation
Contributor
iguinn
commented
Apr 18, 2025
- WaveformTable was managing its ndas itself in certain cases, which created refcheck errors
- WaveformTable.set_wflen required a way to reshape the inner dimensions of arrays, so resize was modified to take collections.
… changes to len/capacity management
… instead of returning n_read
Contributor
Author
|
Github is being strange for me, I think because of the squash merge, and wants to reapply a lot of previous commits to this. I tried moving this work to start at upstream/main, but it doesn't seem to want to update my main on github |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
==========================================
+ Coverage 78.98% 79.17% +0.19%
==========================================
Files 47 47
Lines 3535 3535
==========================================
+ Hits 2792 2799 +7
+ Misses 743 736 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Superseded by #142 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.