Skip to content

Wf table bug fixes - fixes history for #141#142

Merged
ggmarshall merged 2 commits intolegend-exp:mainfrom
ggmarshall:wf_table
Apr 18, 2025
Merged

Wf table bug fixes - fixes history for #141#142
ggmarshall merged 2 commits intolegend-exp:mainfrom
ggmarshall:wf_table

Conversation

@ggmarshall
Copy link
Copy Markdown
Contributor

I copy the desciption from #141:

  • WaveformTable was managing its ndas itself in certain cases, which created refcheck errors
  • WaveformTable.set_wflen required a way to reshape the inner dimensions of arrays, so resize was modified to take collections.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.17%. Comparing base (794f5a7) to head (cfd28db).
Report is 41 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
+ Coverage   78.98%   79.17%   +0.19%     
==========================================
  Files          47       47              
  Lines        3535     3535              
==========================================
+ Hits         2792     2799       +7     
+ Misses        743      736       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ggmarshall ggmarshall merged commit c34272e into legend-exp:main Apr 18, 2025
15 checks passed
@ggmarshall ggmarshall mentioned this pull request Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants