Conversation
`model` helper defines a name for an embedded model, but that name was not used. Now, this model is identified using this name in outer model. This avoid clash when embedding a same model more than once.
Choice content in resultant hash is no more the value of the chosen item, but a hash which key is the item name associated with item value.
b18ffc6 to
c41fea5
Compare
|
Thanks for taking a look! I rebased #45 on this PR and it looks like there's still a {
:LdapMessage => {
:message_id=>1,
:protocol_op=>{
:bind_request=>{
:version=>3,
:name=>"Administrator@adf3.local",
nil=>{
:simple=>"p4$$w0rd"
}
}
}
}
} |
|
I locally merged your branch on mine, and the result is as expected. It seems you rebased 1 commit behind branch head. Branch head is c41fea5. |
|
Apologies, thanks for catching that - the test pass now! 🏆 I was reflecting on your original comment - and I was thinking that the current/original Since this PR would be an API breaking change in terms of behavior for users, I wonder if this something that would make sense as a backwards compatible/opt in API? Maybe Edit: I see now that this PR impacts more than just the |
Model#to_hwhichChoiceelements.