Use fanout for publish if mesh is empty even if we are subscribed to a topic#675
Open
aarshkshah1992 wants to merge 1 commit intolibp2p:masterfrom
Open
Use fanout for publish if mesh is empty even if we are subscribed to a topic#675aarshkshah1992 wants to merge 1 commit intolibp2p:masterfrom
aarshkshah1992 wants to merge 1 commit intolibp2p:masterfrom
Conversation
Contributor
Author
|
@MarcoPolo @sukunrt Please can I request you to take a look ? |
sukunrt
reviewed
Feb 26, 2026
| // to ensure that messages we publish in the intermin are not lost | ||
| if len(gmap) > 0 { | ||
| gs.mesh[topic] = gmap | ||
| } |
Member
There was a problem hiding this comment.
Why do you need this? The len check when we build the list of peers to publish to is enough.
Comment on lines
+1367
to
1370
| if !ok || len(gmap) == 0 { | ||
| // we are not in the mesh for topic, use fanout peers | ||
| gmap, ok = gs.fanout[topic] | ||
| if !ok || len(gmap) == 0 { |
Member
There was a problem hiding this comment.
You can also consider adding:
Dlo - len(gmap) peers from fanout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a peer subscribes to a topic when it has not yet seen any other peers for the topic, it will set the mesh to an empty map.
Now say another peer comes in and subscribes to the topic. But, it has not been grafted yet and has yet to be added to the mesh. However, it is now added to the list of peers subscribed to a given topic.
Now, if the first peer does a Publish -> we see that the mesh exists and so don't do a fanout. However, the mesh is empty which means that the peer above never sees the message.
Later, on a heartbeat, the second peer gets grafted but it's too late.