Skip to content

Use fanout for publish if mesh is empty even if we are subscribed to a topic #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aarshkshah1992 wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −2
Open

Use fanout for publish if mesh is empty even if we are subscribed to a topic #675

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions gossipsub.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1364,7 +1364,7 @@ func (gs *GossipSubRouter) rpcs(msg *Message) iter.Seq2[peer.ID, *RPC] {

// gossipsub peers
gmap, ok := gs.mesh[topic]
if !ok {
if !ok || len(gmap) == 0 {
// we are not in the mesh for topic, use fanout peers
gmap, ok = gs.fanout[topic]
if !ok || len(gmap) == 0 {
Comment on lines +1367 to 1370
Copy link
Member

@sukunrt sukunrt Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also consider adding:
Dlo - len(gmap) peers from fanout.

Expand Down Expand Up @@ -1477,7 +1477,11 @@ func (gs *GossipSubRouter) Join(topic string) {
return !direct && !doBackOff && gs.score.Score(p) >= 0
})
gmap = peerListToMap(peers)
gs.mesh[topic] = gmap
// It is possible that we do not have any peers subscribed to this topic yet so continue fanout
// to ensure that messages we publish in the intermin are not lost
if len(gmap) > 0 {
gs.mesh[topic] = gmap
}
Copy link
Member

@sukunrt sukunrt Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need this? The len check when we build the list of peers to publish to is enough.

}

for p := range gmap {
Expand Down
Loading