chore(tcp): remove async_std support#5955
Conversation
dariusc93
left a comment
There was a problem hiding this comment.
Thanks. Left a couple of comments
jxs
left a comment
There was a problem hiding this comment.
Can we not soft deprecate and just hard deprecate? CC @elenaf9 @dariusc93
@gitToki initially did that, but I asked for a soft deprecation. I think a soft deprecation makes sense here because we might still have users that use Any specific reason why you'd prefer a direct removal @jxs? |
Would there be any reason to suddenly do a hard deprecation vs soft? Imo, I think we should do a soft (though I am not against a hard one) to give users a time to switch or figure out plans on migration (or supporting the executor themselves for the respected protocols and utils). |
|
Hi!
the reason is more work, double the PR's for something that has been declared as unmaintained, I feel redundant to have a version for users to remove their usage when they probably are already removing, added to the fact that I have seen soft deprecations lost in time. |
|
updated, should be good. @dariusc93 please let me know if everything look good to you |
|
This pull request has merge conflicts. Could you please resolve them @gitToki? 🙏 |
|
This pull request has merge conflicts. Could you please resolve them @gitToki? 🙏 |
migrate from async-std to tokio, asked before [here](#5955 (comment)) Pull-Request: #6054.
|
dcutr and mplex fail but only the test have been updated so no version bump. It should be good now |
jxs
left a comment
There was a problem hiding this comment.
Thanks for the patience Toki, left comments
|
This pull request has merge conflicts. Could you please resolve them @gitToki? 🙏 |
ref #5935
crate to update:
swarm, mDNS, and the transports TCP, QUIC and DNS.