feat: deprecate async_std support in DNS crate #5959
feat: deprecate async_std support in DNS crate #5959mergify[bot] merged 9 commits intolibp2p:masterfrom
Conversation
|
@elenaf9 sorry for these |
|
Hi @elenaf9 - what is the status for removing async-std? I saw this was a blocker for #5968 . I have a dependabot alert for the |
There was a problem hiding this comment.
Hi @elenaf9 - what is the status for removing async-std? I saw this was a blocker for #5968 . I have a dependabot alert for the
hickory-protocrate I need to address ASAP. I'm blocked on upgrading myrethdependency until this is updated inrust-libp2p. Is there something I can do to help get this updated?
CI is still failing (see below comment), and rustfmt is needed, rest LGTM.
Edit: #5899 was merged just now, so you probably also need to merge master again and double check the tests that were added in that PR.
Thank you, @elenaf9 🙏 Hi @gitToki, are you still working on this? Would you like any help? |
|
This pull request has merge conflicts. Could you please resolve them @gitToki? 🙏 |
Yes I am sorry for the delay |
|
This pull request has merge conflicts. Could you please resolve them @gitToki? 🙏 |
The test should now work @jxs there are just 2 test that I had to change : |
|
This pull request has merge conflicts. Could you please resolve them @gitToki? 🙏 |
|
This pull request has merge conflicts. Could you please resolve them @gitToki? 🙏 |
|
Actually waiting for request response / swarm / websocket for dns |
|
@gitToki is this PR ready from your side? Edit: actually, CI still fails. |
ref #5935
crate to update:
swarm, mDNS, and the transports TCP, QUIC and DNS.