Skip to content

feat: deprecate async_std support in DNS crate #5959

Merged
mergify[bot] merged 9 commits intolibp2p:masterfrom
gitToki:dns
Jun 24, 2025
Merged

feat: deprecate async_std support in DNS crate #5959
mergify[bot] merged 9 commits intolibp2p:masterfrom
gitToki:dns

Conversation

@gitToki
Copy link
Contributor

@gitToki gitToki commented Mar 26, 2025

ref #5935

crate to update:
swarm, mDNS, and the transports TCP, QUIC and DNS.

Copy link
Member

@elenaf9 elenaf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gitToki

@gitToki
Copy link
Contributor Author

gitToki commented Apr 17, 2025

@elenaf9 sorry for these

@grantkee
Copy link

grantkee commented May 5, 2025

Hi @elenaf9 - what is the status for removing async-std? I saw this was a blocker for #5968 . I have a dependabot alert for the hickory-proto crate I need to address ASAP. I'm blocked on upgrading my reth dependency until this is updated in rust-libp2p. Is there something I can do to help get this updated?

Copy link
Member

@elenaf9 elenaf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @elenaf9 - what is the status for removing async-std? I saw this was a blocker for #5968 . I have a dependabot alert for the hickory-proto crate I need to address ASAP. I'm blocked on upgrading my reth dependency until this is updated in rust-libp2p. Is there something I can do to help get this updated?

CI is still failing (see below comment), and rustfmt is needed, rest LGTM.

Edit: #5899 was merged just now, so you probably also need to merge master again and double check the tests that were added in that PR.

@grantkee
Copy link

grantkee commented May 5, 2025

Hi @elenaf9 - what is the status for removing async-std? I saw this was a blocker for #5968 . I have a dependabot alert for the hickory-proto crate I need to address ASAP. I'm blocked on upgrading my reth dependency until this is updated in rust-libp2p. Is there something I can do to help get this updated?

CI is still failing (see below comment), and rustfmt is needed, rest LGTM.

Thank you, @elenaf9 🙏 Hi @gitToki, are you still working on this? Would you like any help?

@mergify
Copy link
Contributor

mergify bot commented May 5, 2025

This pull request has merge conflicts. Could you please resolve them @gitToki? 🙏

@gitToki
Copy link
Contributor Author

gitToki commented May 7, 2025

Hi @elenaf9 - what is the status for removing async-std? I saw this was a blocker for #5968 . I have a dependabot alert for the hickory-proto crate I need to address ASAP. I'm blocked on upgrading my reth dependency until this is updated in rust-libp2p. Is there something I can do to help get this updated?

CI is still failing (see below comment), and rustfmt is needed, rest LGTM.

Thank you, @elenaf9 🙏 Hi @gitToki, are you still working on this? Would you like any help?

Yes I am sorry for the delay

Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is still failing, can you please take a look @gitToki ?

@mergify
Copy link
Contributor

mergify bot commented May 18, 2025

This pull request has merge conflicts. Could you please resolve them @gitToki? 🙏

@gitToki
Copy link
Contributor Author

gitToki commented May 18, 2025

CI is still failing, can you please take a look @gitToki ?

The test should now work @jxs there are just 2 test that I had to change : identify_external_addr_report and update_address_on_connect in memory_store.rs because of different timing behavior in Tokio's task scheduler and network address format differences.

@mergify
Copy link
Contributor

mergify bot commented May 21, 2025

This pull request has merge conflicts. Could you please resolve them @gitToki? 🙏

@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2025

This pull request has merge conflicts. Could you please resolve them @gitToki? 🙏

@jxs jxs changed the title chore: deprecate async_std support in DNS crate feat: deprecate async_std support in DNS crate Jun 4, 2025
@gitToki
Copy link
Contributor Author

gitToki commented Jun 7, 2025

Actually waiting for request response / swarm / websocket for dns

@gitToki gitToki marked this pull request as draft June 7, 2025 16:25
Copy link
Member

@elenaf9 elenaf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, thanks!

@elenaf9
Copy link
Member

elenaf9 commented Jun 24, 2025

@gitToki is this PR ready from your side?

Edit: actually, CI still fails.

Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patience, LGTM

@jxs jxs marked this pull request as ready for review June 24, 2025 16:57
@jxs jxs added the send-it label Jun 24, 2025
@mergify mergify bot merged commit 7cdf4d5 into libp2p:master Jun 24, 2025
70 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants