fix(upnp): skip port mapping when an active port mapping is present #6127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit aims to fix a bug where a valid listener would be thrown away without attempting a port map. This happens when we have multiple local adapters and the local adapter with the upnp support is not the first one obtained via
NewListenAddr
.With the new change, we would only skip the listen addr if an
Active Mapping
exists for that sameChange checklist