Skip to content

Conversation

RolandSherwin
Copy link
Contributor

@RolandSherwin RolandSherwin commented Aug 11, 2025

Description

This commit aims to fix a bug where a valid listener would be thrown away without attempting a port map. This happens when we have multiple local adapters and the local adapter with the upnp support is not the first one obtained via NewListenAddr.
With the new change, we would only skip the listen addr if an Active Mapping exists for that same

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, let me fix the CI first on another PR

@RolandSherwin RolandSherwin force-pushed the upnp_skip_if_active_map branch from 27d291b to 5a35dbc Compare August 13, 2025 05:14
@jxs jxs added the send-it label Aug 22, 2025
@mergify mergify bot merged commit 1755bca into libp2p:master Aug 22, 2025
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants