Save non-alpha pngs as RGB not RGBA, handle arbitrary surface pitch properly (miniz backend) #560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankith26
force-pushed
the
ankith26-save-rgb-png
branch
3 times, most recently
from
25cdca2 to
c996880
Compare
|
As a side goal of this PR, the code is now more robust and handles arbitrary pitches. It seems like miniz always expects a tight pitch (and generates corrupted PNGs if this isn't the case), but the input surface or the surface output of |
ankith26
changed the title
ankith26
force-pushed
the
ankith26-save-rgb-png
branch
from
c996880 to
6a42626
Compare
slouken
reviewed
Aug 1, 2025
|
SDL_PIXELFORMAT_RGB24 is the slowest format to convert to. Does the libpng code actually do this? |
Co-authored-by: Sam Lantinga <[email protected]>
|
Yes, the libpng backend does convert to |
|
I think this change would be okay in SDL3, but we shouldn't change SDL2 behavior at this point. Feel free to open a new PR against main if it's still relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to make the behaviour of SavePNG more consistent across backends (miniz and libpng). With this PR, images that don't need alpha will now be stored as RGB instead of RGBA.