fix: avoid dropping frames before H.264 decoding#904
Open
Woodii1998 wants to merge 2 commits intolichtblick-suite:developfrom
Open
fix: avoid dropping frames before H.264 decoding#904Woodii1998 wants to merge 2 commits intolichtblick-suite:developfrom
Woodii1998 wants to merge 2 commits intolichtblick-suite:developfrom
Conversation
Contributor
|
Hi @Woodii1998, we'll take a look at this when appropriate. Regarding the H.265 (HEVC) decoding, it's not something we're actively looking into, so definitely have a go at it if you'd like. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Changes
Fixes incorrect video output when playing H.264 streams at high speed or with long GOP intervals by ensuring frames are not filtered out before decoding.
Description
Currently, some frames are filtered out before being passed to the WebCodecs decoder.
This breaks H.264 decoding because inter frames depend on previous reference frames, which can lead to visual corruption, especially when:
This PR removes the pre-decode frame filtering logic and always feeds a complete frame sequence into the decoder, ensuring correct reference frame handling and stable playback for compressed video streams.
You can reproduce the issue using the file below by playing it at 5× speed.
https://drive.google.com/file/d/1z6PnopbkXyMWdln4h-u5rIw_p1pB6v15/view?usp=drive_link
Additionally, this PR removes a duplicated condition check inside an
ifstatement to simplify the logic and improve code clarity.I also wanted to ask: is there any plan to support H.265 (HEVC) decoding in this project?
If so, I would be happy to help contribute support for it.
Checklist