fix(VaultHub): add safe cast for reported values#1755
Merged
folkyatina merged 2 commits intorelease/3.0.2from Mar 31, 2026
Merged
fix(VaultHub): add safe cast for reported values#1755folkyatina merged 2 commits intorelease/3.0.2from
folkyatina merged 2 commits intorelease/3.0.2from
Conversation
|
Hardhat Unit Tests Coverage SummaryDetailsDiff against masterResults for commit: cbcc6d1 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
_applyVaultReport(), the oracle-reported_reportSlashingReservevalue (uint256) is downcastto uint128 without using SafeCast, despite the contract importing it. Solidity 0.8.25 does not
check explicit narrowing type conversions -- higher-order bits are silently truncated. If
_reportSlashingReserveexceedstype(uint128).max, theminimalReservewould be set to anincorrect (lower) value, undermining slashing reserve enforcement.
While
type(uint128).max(~3.4 * 10^38 wei, ~3.4 * 10^20 ETH) far exceeds any realistic value, theinconsistency with the contract's own SafeCast import suggests the check was intended but
overlooked. Similar unchecked downcasts exist for
_reportCumulativeLidoFeesand other fields in the Report struct.Recommendations:
Use
SafeCast.toUint128()for the downcast to ensure a clean revert with adescriptive error rather than silent truncation in edge cases. Apply the same treatment to other
unchecked downcasts in
_applyVaultReport().