Skip to content

fix(VaultHub): add safe cast for reported values #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
folkyatina merged 2 commits into from
Mar 31, 2026
Merged

fix(VaultHub): add safe cast for reported values #1755

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
702ef9d
fix(VaultHub): add safe cast for reported values
folkyatina Mar 31, 2026
cbcc6d1
chore: deploy mainnet
dry914 Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions contracts/0.8.25/vaults/VaultHub.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1107,8 +1107,8 @@ contract VaultHub is PausableUntilWithRoles {
uint256 _reportMaxLiabilityShares,
uint256 _reportSlashingReserve
) internal {
_record.cumulativeLidoFees = uint128(_reportCumulativeLidoFees);
_record.minimalReserve = uint128(Math256.max(CONNECT_DEPOSIT, _reportSlashingReserve));
_record.cumulativeLidoFees = SafeCast.toUint128(_reportCumulativeLidoFees);
_record.minimalReserve = SafeCast.toUint128(Math256.max(CONNECT_DEPOSIT, _reportSlashingReserve));

// We want to prevent 1 tx looping here:
// 1. bring ETH (TV+)
Expand All @@ -1121,8 +1121,10 @@ contract VaultHub is PausableUntilWithRoles {
// if any stETH is minted on funds added after the refslot
// in that case we don't update it (preventing unlock)
if (_record.maxLiabilityShares == _reportMaxLiabilityShares) {
_record.maxLiabilityShares = uint96(Math256.max(_record.liabilityShares, _reportLiabilityShares));
_record.maxLiabilityShares = SafeCast.toUint96(Math256.max(_record.liabilityShares, _reportLiabilityShares));
}

// report values is not safecasted because they're checked extensively in LazyOracle
_record.report = Report({
totalValue: uint104(_reportTotalValue),
inOutDelta: int104(_reportInOutDelta),
Expand Down
Loading