Drop tokio/macros dependency in lightning-net-tokio, fix MSRV
#2426
Conversation
TheBlueMatt
force-pushed
the
2023-07-proc-macro2-msrv
branch
3 times, most recently
from
3727396 to
9c2d4c6
Compare
TheBlueMatt
force-pushed
the
2023-07-proc-macro2-msrv
branch
2 times, most recently
from
818144e to
7b29d2c
Compare
|
Okay, sorry for the noise, this should be good to go now. Note that we now have a new CI task which checks our code with only the deps we have as release dependencies pinned - these are the ones that are painful as our users have to do it too - and separately pin the dependencies that are only dev-dependencies. |
TheBlueMatt
force-pushed
the
2023-07-proc-macro2-msrv
branch
3 times, most recently
from
2742d86 to
55071ac
Compare
The `tokio` `macros` feature depends on `proc-macro2`, which recently broke its MSRV in a patch version. Such crates aren't reasonable for us to have as dependencies, so instead we replace the one trivial use we have of `tokio::select!()` with our own manual future.
The proc-macro2 crate switched to Rust edition 2021 starting with v1.0.66, i.e., has MSRV of 1.56. Here, we pin it in CI to fix the breakage.
TheBlueMatt
force-pushed
the
2023-07-proc-macro2-msrv
branch
from
55071ac to
f6e0ad2
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2426 +/- ##
==========================================
- Coverage 90.27% 90.27% -0.01%
==========================================
Files 106 106
Lines 55664 55691 +27
Branches 55664 55691 +27
==========================================
+ Hits 50249 50273 +24
- Misses 5415 5418 +3
☔ View full report in Codecov by Sentry. |
This should fix CI
|
Grrr, somehow we were trying to build |
5 participants
The
tokiomacrosfeature depends onproc-macro2, which recently broke its MSRV in a patch version. Such crates aren't reasonable for us to have as dependencies, so instead we replace the one trivial use we have oftokio::select!()with our own manual future.This is an alternative to #2424.