Skip to content

Drop tokio/macros dependency in lightning-net-tokio, fix MSRV #2426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 19, 2023
Merged

Drop tokio/macros dependency in lightning-net-tokio, fix MSRV #2426

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fd24643
Drop `tokio/macros` dependency in `lightning-net-tokio`, fix MSRV
TheBlueMatt Jul 17, 2023
4ab32f9
Test MSRV builds (without dev-dependencies) in CI
TheBlueMatt Jul 17, 2023
f6e0ad2
Pin `proc-macro2` in CI to fix MSRV breakage
tnull Jul 17, 2023
f38b80a
Only try to build `lightning-transaction-sync` if we meet its MSRV
TheBlueMatt Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ci/ci-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,12 @@ popd
echo -e "\n\nTesting no-std build on a downstream no-std crate"
# check no-std compatibility across dependencies
pushd no-std-check
cargo check --verbose --color always --features lightning-transaction-sync
if [[ $RUSTC_MINOR_VERSION -gt 67 ]]; then
# lightning-transaction-sync's MSRV is 1.67
cargo check --verbose --color always --features lightning-transaction-sync
else
cargo check --verbose --color always
fi
popd

# Test that we can build downstream code with only the "release pins".
Expand Down