Make clippy shut up about PartialOrd and Ord both impl'd
#2650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clippy gets mad that we have an implementation of `ParialOrd` and `Ord` separately, even though both are identical. Making `ParitalOrd` call `Ord` makes clippy shut up.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2650 +/- ##
=======================================
Coverage 89.00% 89.01%
=======================================
Files 112 112
Lines 87157 87157
Branches 87157 87157
=======================================
+ Hits 77574 77580 +6
Misses 7339 7339
+ Partials 2244 2238 -6
☔ View full report in Codecov by Sentry. |
wpaulino
approved these changes
Oct 10, 2023
jkczyz
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clippy gets mad that we have an implementation of
ParialOrdandOrdseparately, even though both are identical. MakingParitalOrdcallOrdmakes clippy shut up.