Fix Channel being left in indeterminite state from 9f9a7a92e1c15cad #3627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9f9a7a9 introduced some changes to channel state transitions but left one case where we'd leave a channel in an undefined phase (upon receiving a `commitment_signed` in the wrong state), which we fix here.
dunxen
approved these changes
Feb 27, 2025
Contributor
dunxen
left a comment
dunxen
left a comment
There was a problem hiding this comment.
Ugh. Sorry, I definitely messed this up after rebasing the phase refactor. :(
Collaborator
Author
|
Long PRs with many rebases and rounds of review introduce way too many bugs... |
Contributor
|
This LGTM, maybe @jkczyz could perhaps take a look and then merge as he also has context. |
jkczyz
approved these changes
Feb 28, 2025
| }, | ||
| _ => { | ||
| self.phase = phase; | ||
| debug_assert!(!matches!(self.phase, ChannelPhase::Undefined)); |
Contributor
There was a problem hiding this comment.
Ah, the debug_assert should have probably gone outside the match as is done in funding_signed. Guess it doesn't really matter since the other arms should be obviously correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9f9a7a9 introduced some changes to channel state transitions but left one case where we'd leave a channel in an undefined phase (upon receiving a
commitment_signedin the wrong state), which we fix here.