Skip to content

Fix Channel being left in indeterminite state from 9f9a7a92e1c15cad #3627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Fix Channel being left in indeterminite state from 9f9a7a92e1c15cad #3627

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lightning/src/ln/channel.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1534,6 +1534,7 @@ impl<SP: Deref> Channel<SP> where
res
},
_ => {
self.phase = phase;
debug_assert!(!matches!(self.phase, ChannelPhase::Undefined));
Copy link
Contributor

@jkczyz jkczyz Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the debug_assert should have probably gone outside the match as is done in funding_signed. Guess it doesn't really matter since the other arms should be obviously correct.

Err(ChannelError::close("Got a commitment_signed message for an unfunded V1 channel!".into()))
}
Expand Down
Loading