Skip beta builds on macos an windows #3958
Conversation
|
I've assigned @tankyleo as a reviewer! |
TheBlueMatt
force-pushed
the
2025-07-less-winblowz
branch
from
733e889 to
9f55cc5
Compare
While we should keep testing MacOS and Windows builds (especially Winblowz since its somehow still cooperative multitasking within a process in 2025), there's not a lot of need to test rustc beta builds on them, which we mostly do just to ensure we aren't going to be broken by a future rustc update that breaks some API (which is exceedingly rare). This should get our CI queueing times back close to zero on all jobs.
TheBlueMatt
force-pushed
the
2025-07-less-winblowz
branch
from
9f55cc5 to
2bbea3b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3958 +/- ##
==========================================
+ Coverage 88.72% 88.92% +0.19%
==========================================
Files 172 173 +1
Lines 123553 123794 +241
Branches 123553 123794 +241
==========================================
+ Hits 109625 110084 +459
+ Misses 11552 11249 -303
- Partials 2376 2461 +85
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
| toolchain: [ stable, beta, 1.63.0 ] # 1.63.0 is the MSRV for all crates but `lightning-transaction-sync`. | ||
| exclude: | ||
| - platform: windows-latest | ||
| toolchain: 1.63.0 |
There was a problem hiding this comment.
Why not also exclude 1.63 on macOS?
There was a problem hiding this comment.
We should still support the MSRV if we have any macOS-dependent code. The only reason its skipped on Windows is we don't support an MSRV on Windows because of some dependency crap (but maybe we could now that we build tx-sync separately?).
I pushed an update to test if WIndows builds with 1.63 again.
There was a problem hiding this comment.
Lol, nevermind 🤷♂️
error: "D:\a\rust-lightning\rust-lightning\target\doc\windows_sys\all.html": The system cannot find the path specified. (os error 3)
error: couldn't generate documentation: I/O error
error: could not document `windows-sys`
There was a problem hiding this comment.
Yes, in this case lightning-transaction-sync wasn't the culprit for once.
TheBlueMatt
force-pushed
the
2025-07-less-winblowz
branch
from
035ed04 to
2bbea3b
Compare
There was a problem hiding this comment.
IIRC, sometime in the past there was an issue that was only appearing on macOS and Rust beta channel (can't fully recall though). I guess we can/should still do this, but want to note that we of course reduce coverage a bit, but that's probably okay.
Landing this as it's simple enough.
6 participants
While we should keep testing MacOS and Windows builds (especially Winblowz since its somehow still cooperative multitasking within a process in 2025), there's not a lot of need to test rustc beta builds on them, which we mostly do just to ensure we aren't going to be broken by a future rustc update that breaks some API (which is exceedingly rare).
This should get our CI queueing times back close to zero on all jobs.