Skip to content

Skip beta builds on macos an windows #3958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2025
Merged

Skip beta builds on macos an windows #3958

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ jobs:
exclude:
- platform: windows-latest
toolchain: 1.63.0
Copy link
Contributor

@wpaulino wpaulino Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not also exclude 1.63 on macOS?

Copy link
Collaborator Author

@TheBlueMatt TheBlueMatt Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should still support the MSRV if we have any macOS-dependent code. The only reason its skipped on Windows is we don't support an MSRV on Windows because of some dependency crap (but maybe we could now that we build tx-sync separately?).

I pushed an update to test if WIndows builds with 1.63 again.

Copy link
Collaborator Author

@TheBlueMatt TheBlueMatt Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, nevermind 🤷‍♂️

error: "D:\a\rust-lightning\rust-lightning\target\doc\windows_sys\all.html": The system cannot find the path specified. (os error 3)

error: couldn't generate documentation: I/O error

error: could not document `windows-sys`

Copy link
Contributor

@tnull tnull Jul 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in this case lightning-transaction-sync wasn't the culprit for once.

- platform: windows-latest
toolchain: beta
- platform: macos-latest
toolchain: beta
runs-on: ${{ matrix.platform }}
steps:
- name: Checkout source code
Expand Down
Loading