Describe ConfirmationTarget::MaximumFeeEstimate more accurately
#4043
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't really just the maximum estimate that we want from our fee estimator but rather the maximum estimate that we think is reasonable to receive from our counterparty. Thus, we should really describe it as such and suggest users add a fudge on top to accomodate disagreements.
|
👋 Thanks for assigning @tnull as a reviewer! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4043 +/- ##
==========================================
- Coverage 88.74% 88.73% -0.01%
==========================================
Files 176 176
Lines 129105 129105
Branches 129105 129105
==========================================
- Hits 114574 114562 -12
- Misses 11933 11942 +9
- Partials 2598 2601 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tnull
approved these changes
Sep 2, 2025
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't really just the maximum estimate that we want from our fee estimator but rather the maximum estimate that we think is reasonable to receive from our counterparty. Thus, we should really describe it as such and suggest users add a fudge on top to accomodate disagreements.