Skip to content

Describe ConfirmationTarget::MaximumFeeEstimate more accurately #4043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2025
+5 −2
Merged

Describe ConfirmationTarget::MaximumFeeEstimate more accurately #4043

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lightning/src/chain/chaininterface.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,14 @@ pub trait BroadcasterInterface {
/// estimation.
#[derive(Clone, Copy, Debug, Hash, PartialEq, Eq)]
pub enum ConfirmationTarget {
/// The most aggressive (i.e. highest) feerate estimate available.
/// The most aggressive feerate estimate which we think is reasonable.
///
/// This is used to sanity-check our counterparty's feerates and should be as conservative as
/// possible to ensure that we don't confuse a peer using a very conservative estimator for one
/// trying to burn channel balance to dust.
/// trying to burn channel balance to dust. To ensure that this is never lower than an honest
/// counterparty's feerate estimate you may wish to use a value which is higher than your
/// maximum feerate estimate, for example by adding a constant few-hundred or few-thousand
/// sats-per-kW.
MaximumFeeEstimate,
/// We have some funds available on chain which we need to spend prior to some expiry time at
/// which point our counterparty may be able to steal them.
Expand Down
Loading