- 
                Notifications
    You must be signed in to change notification settings 
- Fork 109
multi: update to latest versions, prepare for RC2 #1082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Some flags that didn't make sense were removed when cleaning up the keysend usecase, but some of them are still useful and we add them back.
Adds a test case to validate the fix in lightninglabs/taproot-assets#1583, by adding a test that: - Creates two asset channels between Alice and Bob - Creates a BTC channel between Bob and Charlie - The two asset channels each have a different asset in them - The balance of the pences channel is decreased (lower bandwidth) - An RFQ payment is attempted, with pences as the payment asset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just doing some local testing before hitting the ACK. Just leaving some nits meanwhile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK 🔥
| } | ||
|  | ||
| // testCustomChannelsMultiChannelPathfinding tests that multiple channels with | ||
| // different assets are properly considered when pathfinding for payments. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be nice to add the topology here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
go.modto the latest versions of all available projects.