Skip to content

Conversation

@guggero
Copy link
Contributor

@guggero guggero commented Jun 4, 2025

  1. Updates go.mod to the latest versions of all available projects.
  2. Adds back two payment flags that were removed by accident.
  3. Adds an integration test to reproduce (and propose a fix for) [bug]: non-deterministic behavior when circular cross-channel type payments are attempted  taproot-assets#1279.
  4. Adds an integration test to cover channels: check RFQ quote compatibility with channel at pathfind time taproot-assets#1583.
  5. Add self-payment backward compatibility test
  6. Bump to RC2

guggero added 7 commits June 5, 2025 16:33
Some flags that didn't make sense were removed when cleaning up the
keysend usecase, but some of them are still useful and we add them back.
Adds a test case to validate the fix in
lightninglabs/taproot-assets#1583, by adding a test that:
 - Creates two asset channels between Alice and Bob
 - Creates a BTC channel between Bob and Charlie
 - The two asset channels each have a different asset in them
 - The balance of the pences channel is decreased (lower bandwidth)
 - An RFQ payment is attempted, with pences as the payment asset
@guggero guggero force-pushed the lnd-19-final-mod branch from 6012478 to 41e3bed Compare June 5, 2025 14:35
@guggero guggero marked this pull request as ready for review June 5, 2025 14:35
Copy link
Contributor

@ViktorT-11 ViktorT-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just doing some local testing before hitting the ACK. Just leaving some nits meanwhile.

@levmi levmi requested a review from GeorgeTsagk June 5, 2025 15:44
Copy link
Contributor

@ViktorT-11 ViktorT-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 🔥

@guggero guggero force-pushed the lnd-19-final-mod branch from 41e3bed to d4550fc Compare June 5, 2025 16:06
}

// testCustomChannelsMultiChannelPathfinding tests that multiple channels with
// different assets are properly considered when pathfinding for payments.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to add the topology here

Copy link
Member

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@guggero guggero merged commit f4a5883 into master Jun 6, 2025
22 checks passed
@guggero guggero deleted the lnd-19-final-mod branch June 6, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants