itest: taproot assets forwarding history#1222
Conversation
Summary of ChangesHello @darioAnongba, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's Go environment and dependencies to ensure compatibility and leverage the latest features and fixes. Crucially, it enhances the robustness of Taproot Assets integration tests by adding comprehensive verification for forwarding history events, ensuring that asset transfers are correctly recorded and retrievable within the system. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds verification for Taproot Asset forwarding history in the integration tests. A new helper function waitForForwardingEvent is introduced to poll for forwarding events.
The overall approach is good, but I've found a potential issue in the implementation of the new test logic. The helper function and its usage currently only account for single forwarding events, which may not be sufficient for multi-part payments (MPP). This could lead to incomplete verification in tests. I've left detailed comments with suggestions on how to make the test more robust to handle MPP scenarios.
1e6e20c to
b5cde0f
Compare
b5cde0f to
d13bb40
Compare
Adds
ForwardingHistoryverification in thecustom_channelsitests.