Add lastHop parameter for loop in quotes #920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsrachelfish
force-pushed
the
loop-in-quote-fix
branch
from
371fb7f to
d2a2edd
Compare
ViktorT-11
approved these changes
Dec 17, 2024
Contributor
ViktorT-11
left a comment
ViktorT-11
left a comment
There was a problem hiding this comment.
LGTM! Could be worth getting an ACK from someone that works with the LiT frontend code as well :)
Member
|
The code LGTM but haven't tested. Tagging @jbrill for review since I am OOO this week. |
jamaljsr
approved these changes
Jan 2, 2025
itsrachelfish
force-pushed
the
loop-in-quote-fix
branch
from
d2a2edd to
83da8fb
Compare
Contributor
Author
|
@jamaljsr Rebased and updated my release notes to use the new v0.14.1 file |
itsrachelfish
force-pushed
the
loop-in-quote-fix
branch
from
83da8fb to
99057f7
Compare
|
@jbrill: review reminder |
jbrill
approved these changes
Jan 24, 2025
jbrill
left a comment
jbrill
left a comment
There was a problem hiding this comment.
LGTM! Sorry about the delayed review
Might just need a rebase on the release notes!
itsrachelfish
force-pushed
the
loop-in-quote-fix
branch
from
99057f7 to
a1ae2bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #904
Was able to reproduce this bug on regtest by changing the fee rate on one of my test nodes.
Fix was pretty simple because the
swapViewand loop protobuf definitons already had all of the necessary variables and functions defined 🎉