Skip to content

Add lastHop parameter for loop in quotes #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Add lastHop parameter for loop in quotes #920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/src/api/loop.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,12 @@ class LoopApi extends BaseApi<LoopEvents> {
async getLoopInQuote(
amount: Big,
confTarget?: number,
lastHop?: string,
): Promise<LOOP.InQuoteResponse.AsObject> {
const req = new LOOP.QuoteRequest();
req.setAmt(amount.toString());
if (confTarget) req.setConfTarget(confTarget);
if (lastHop) req.setLoopInLastHop(b64(lastHop));
const res = await this._grpc.request(SwapClient.GetLoopInQuote, req, this._meta);
return res.toObject();
}
Expand Down
1 change: 1 addition & 0 deletions app/src/store/views/buildSwapView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,6 +426,7 @@ class BuildSwapView {
const inQuote = await this._store.api.loop.getLoopInQuote(
amount,
this.confTarget,
this.loopInLastHop,
);
quote = {
swapFee: Big(inQuote.swapFeeSat),
Expand Down
9 changes: 7 additions & 2 deletions docs/release-notes/release-notes-0.14.1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@

### Bug Fixes

* [Add `lastHop` parameter for Loop In
quotes](https://github.com/lightninglabs/lightning-terminal/pull/920).
Fixes fee estimation bug when using Loop In for a specific channel.

### Functional Changes/Additions

### Technical and Architectural Updates
Expand All @@ -36,7 +40,7 @@

### Pool

### Faraday
### Faradayaa

* The integrated `faraday` instance was
[updated](https://github.com/lightninglabs/lightning-terminal/pull/952) to
Expand All @@ -55,5 +59,6 @@
* Elle Mouton
* jiangmencity
* Oliver Gugger
* Rachel Fish
* Tristav
* zhoufanjin
* zhoufanjin
Loading