Skip to content

Conversation

@gijswijs
Copy link
Contributor

@gijswijs gijswijs commented Oct 29, 2024

Added MinRelayFee func to walletkit_client.go.

Pull Request Checklist

  • PR is opened against correct version branch.
  • Version compatibility matrix in the README and minimal required version
    in lnd_services.go are updated.
  • Update macaroon_recipes.go if your PR adds a new method that is called
    differently than the RPC method it invokes.

Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

Copy link
Contributor

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

I though we could do this against the master branch, but it turns out the new field was actually only added in 0.18.x, so lnd-18-4 is the correct branch.

@gijswijs gijswijs force-pushed the minrelayfee branch 2 times, most recently from da11abd to 108aadd Compare October 29, 2024 20:40
@guggero
Copy link
Contributor

guggero commented Oct 30, 2024

Can you squash the commits? Then I think we can merge this. Or is anything else missing here? Just waiting to confirm everything works in tapd?

Added MinRelayFee func to walletkit_client.go.
@gijswijs gijswijs marked this pull request as ready for review October 30, 2024 17:14
@gijswijs
Copy link
Contributor Author

gijswijs commented Oct 30, 2024

Just waiting to confirm everything works in tapd?

Exactly. All seems to work. So we have a cascade of PRs depending on this one.

@guggero guggero merged commit 895a850 into lnd-18-4 Oct 30, 2024
1 check passed
@guggero guggero deleted the minrelayfee branch October 30, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants