build: bump tapd to v0.6.1 and lnd to v0.19.2-beta #985
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @bhandras, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on updating the project's Go module dependencies to their latest stable or beta versions, most notably for taproot-assets and lnd. This ensures the project benefits from the latest features, bug fixes, and security improvements from these critical upstream components. A minor code change was also necessary to adapt to an updated API in one of the bumped libraries.
Highlights
- Core Dependency Updates: I've bumped the
taproot-assets(tapd) dependency from a release candidate (v0.6.0-rc2) to its stablev0.6.1version, andlndfromv0.19.0-betatov0.19.2-beta. These are significant updates to key components. - Related Go Module Bumps: Several other Go modules have been updated to align with the new
lndandtaproot-assetsversions, includingbtcwallettov0.16.14,btclog/v2to a newer commit,lndclienttov0.19.0-12, andtaproot-assets/taprpctov1.0.8. - API Adaptation: The
test/chainnotifier_mock.gofile has been updated to reflect an API change inlndclient, specifically by adding a newlndclient.NotifierOptionparameter to theRegisterSpendNtfnfunction signature. - Dependency Cleanup: The indirect dependency
github.com/go-errors/errorshas been removed fromgo.modandgo.sum, indicating it's no longer required by the project's dependency tree.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request bumps several key dependencies, including tapd to v0.6.1 and lnd to v0.19.2-beta. The code changes correctly adapt a mock to an updated interface from one of the dependencies. The changes look correct. I've added one comment regarding the need to update release notes for these significant dependency changes.
| github.com/lightninglabs/taproot-assets v0.6.1 | ||
| github.com/lightninglabs/taproot-assets/taprpc v1.0.8-0.20250617163017-cf2a5e5bb47c | ||
| github.com/lightningnetwork/lnd v0.19.2-beta |
There was a problem hiding this comment.
Bumping these core dependencies (tapd and lnd) is a significant change. To help users and other developers understand the impact, it's important to document this in the release notes as indicated by the PR checklist. Could you please update release_notes.md to reflect the changes introduced by these new versions?
hieblmi
left a comment
hieblmi
left a comment
There was a problem hiding this comment.
LGTM! instantout/reservation/actions_test.go also needs the options argument.
done! |
3 participants
Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes