Skip to content

Conversation

@camposandro
Copy link
Contributor

When selecting columns for a NestedFrame, ensure that the error message only lists non-existent nested columns specified by the user. Previously, all specified nested columns would appear. Closes astronomy-commons/lsdb#1017.

@camposandro camposandro requested a review from dougbrn January 5, 2026 19:13
@camposandro camposandro self-assigned this Jan 5, 2026
@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.36%. Comparing base (27a7e28) to head (4b30e17).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #425      +/-   ##
==========================================
+ Coverage   97.27%   97.36%   +0.08%     
==========================================
  Files          19       19              
  Lines        2094     2126      +32     
==========================================
+ Hits         2037     2070      +33     
+ Misses         57       56       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Before [539d2f3] After [16ebe61] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.ReadFewColumnsS3.peakmem_run
failed failed n/a benchmarks.ReadFewColumnsS3.time_run
66.6±1ms 67.8±0.9ms 1.02 benchmarks.CountNestedBy.time_run
183M 186M 1.02 benchmarks.ReadFewColumnsHTTPS.peakmem_run
48.8±2ms 49.5±0.04ms 1.01 benchmarks.ReassignHalfOfNestedSeries.time_run
137M 137M 1.00 benchmarks.CountNestedBy.peakmem_run
105M 105M 1.00 benchmarks.NestedFrameAddNested.peakmem_run
110M 110M 1.00 benchmarks.NestedFrameQuery.peakmem_run
109M 109M 1.00 benchmarks.NestedFrameReduce.peakmem_run
263M 263M 1.00 benchmarks.ReassignHalfOfNestedSeries.peakmem_run

Click here to view all benchmarks.

Copy link
Collaborator

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, reading through #390 I'm not 100% sure if this addresses it as well or not. If you think it closes it feel free to add it, otherwise @hombit can probably check sometime in the future to see if it's been addressed (not blocking this PR)

@camposandro
Copy link
Contributor Author

Thanks for bringing it up, @dougbrn!

I'm not totally sure either - for some reason, I'm even interpreting it as the opposite of what I implemented. I will wait for @hombit's input just to be sure these two issues do not conflict.

@hombit
Copy link
Collaborator

hombit commented Jan 12, 2026

@camposandro @dougbrn that's good with me, let's solve #390 separately in the future (maybe just on the read_parquet end)

@camposandro camposandro merged commit 4d33df4 into main Jan 12, 2026
12 checks passed
@camposandro camposandro deleted the sandro/missing-col-msg branch January 12, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve error message for selected nested columns

4 participants