Skip to content

Display non-existing nested columns in error message #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camposandro merged 3 commits into from
Jan 12, 2026
Merged

Display non-existing nested columns in error message #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b7c4886
Improve error message for missing columns
camposandro Dec 22, 2025
a3c9970
Implement our own custom message
camposandro Jan 5, 2026
4b30e17
Fix pre-commit
camposandro Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/nested_pandas/nestedframe/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,19 +255,18 @@ def _getitem_str(self, item):
else:
raise KeyError(f"Column '{cleaned_item}' not found in nested columns or base columns")

def _is_key_list(self, item):
@staticmethod
def _is_key_list(item):
if not is_list_like(item):
return False
if is_bool_dtype(item):
return False
for k in item:
if not isinstance(k, str):
return False
if not self._is_known_column(k):
return False
return True
return all(isinstance(k, str) for k in item)

def _getitem_list(self, item):
unknown_cols = [k for k in item if not self._is_known_column(k)]
if unknown_cols:
raise KeyError(f"{unknown_cols} not in index")
non_nested_keys = [k for k in item if k in self.columns]
result = super().__getitem__(non_nested_keys)
components = [self._parse_hierarchical_components(k) for k in item]
Expand Down
19 changes: 11 additions & 8 deletions tests/nested_pandas/nestedframe/test_nestedframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import re

import numpy as np
import pandas as pd
import pyarrow as pa
Expand Down Expand Up @@ -246,14 +248,15 @@ def test_get_nested_columns_errors():

base = base.join_nested(nested, "nested")

with pytest.raises(KeyError):
base[["a", "c"]]

with pytest.raises(KeyError):
base[["a", "nested.g"]]

with pytest.raises(KeyError):
base[["a", "nested.a", "wrong.b"]]
# Escaping the list of columns for a strict check
with pytest.raises(KeyError, match=re.escape("['c']")):
_ = base[["a", "c"]]
with pytest.raises(KeyError, match=re.escape("['nested.g']")):
_ = base[["a", "nested.c", "nested.g"]]
with pytest.raises(KeyError, match=re.escape("['wrong.b']")):
_ = base[["a", "nested.c", "wrong.b"]]
with pytest.raises(KeyError, match=re.escape("['c', 'wrong.b']")):
_ = base[["c", "nested.c", "wrong.b"]]


def test_getitem_empty_bool_array():
Expand Down