Issue/courier 1006 by aaronware · Pull Request #384 · linchpin/courier-notices

aaronware · 2025-07-17T15:40:16Z

No description provided.

improve(COURIER-1006): Implement Strauss for dependency prefixing

linchpin-bot

Code analysis identified issues

action-phpcs-code-review has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.

phpcs scanning turned up:

🚫 6 errors

Powered by rtCamp's GitHub Actions Library

linchpin-bot · 2025-07-17T15:41:10Z

.php-cs-fixer.dist.php

@@ -13,8 +13,6 @@
 $finder = PhpCsFixer\Finder::create()->in(


🚫 Error: Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$finder" (WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound).

.php-cs-fixer.dist.php

courier-notices.php

feat(COURIER-1006): Implement Prettier feat(COURIER-1006): Add precommit linting feat(COURIER-1006): Add phpstan including baseline

linchpin-bot

Code analysis identified issues

action-phpcs-code-review has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.

phpcs scanning turned up:

🚫 19 errors

⚠️ 1 warning

Powered by rtCamp's GitHub Actions Library

Posting will continue in further review(s)

linchpin-bot · 2025-07-18T14:43:34Z

tools/phpstan/constants.php

+}
+
+if ( ! class_exists( 'WP_CLI' ) ) {
+	class WP_CLI {


🚫 Error: Classes declared by a theme/plugin should start with the theme/plugin prefix. Found: "WP_CLI" (WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedClassFound).

linchpin-bot · 2025-07-18T14:43:35Z

tools/phpstan/constants.php

+}
+
+if ( ! class_exists( 'WP_CLI' ) ) {
+	class WP_CLI {


🚫 Error: Missing doc comment for class WP_CLI (Squiz.Commenting.ClassComment.Missing).

linchpin-bot · 2025-07-18T14:43:35Z

tools/phpstan/constants.php

+
+if ( ! class_exists( 'WP_CLI' ) ) {
+	class WP_CLI {
+		public static function add_command( $name, $callable, $args = [] ) {}


🚫 Error: Missing doc comment for function add_command() (Squiz.Commenting.FunctionComment.Missing).

linchpin-bot · 2025-07-18T14:43:35Z

tools/phpstan/constants.php

+
+if ( ! class_exists( 'WP_CLI' ) ) {
+	class WP_CLI {
+		public static function add_command( $name, $callable, $args = [] ) {}


⚠️ Warning: It is recommended not to use reserved keyword "callable" as function parameter name. Found: $callable (Universal.NamingConventions.NoReservedKeywordParameterNames.callableFound).

linchpin-bot · 2025-07-18T14:43:35Z

tools/phpstan/constants.php

+if ( ! class_exists( 'WP_CLI' ) ) {
+	class WP_CLI {
+		public static function add_command( $name, $callable, $args = [] ) {}
+		public static function error( $message ) {}


🚫 Error: Missing doc comment for function error() (Squiz.Commenting.FunctionComment.Missing).

linchpin-bot · 2025-07-18T14:43:35Z

tools/phpstan/constants.php

+	class WP_CLI {
+		public static function add_command( $name, $callable, $args = [] ) {}
+		public static function error( $message ) {}
+		public static function success( $message ) {}


🚫 Error: Missing doc comment for function success() (Squiz.Commenting.FunctionComment.Missing).

linchpin-bot · 2025-07-18T14:43:35Z

tools/phpstan/constants.php

+		public static function add_command( $name, $callable, $args = [] ) {}
+		public static function error( $message ) {}
+		public static function success( $message ) {}
+		public static function warning( $message ) {}


🚫 Error: Missing doc comment for function warning() (Squiz.Commenting.FunctionComment.Missing).

linchpin-bot · 2025-07-18T14:43:35Z

tools/phpstan/constants.php

+		public static function error( $message ) {}
+		public static function success( $message ) {}
+		public static function warning( $message ) {}
+		public static function log( $message ) {}


🚫 Error: Missing doc comment for function log() (Squiz.Commenting.FunctionComment.Missing).

linchpin-bot · 2025-07-18T14:43:35Z

tools/phpstan/constants.php

+
+// Mock Action Scheduler functions.
+if ( ! function_exists( 'as_schedule_single_action' ) ) {
+	function as_schedule_single_action( $timestamp, $hook, $args = [], $group = '' ) {}


🚫 Error: A file should either contain function declarations or OO structure declarations, but not both. Found 3 function declaration(s) and 2 OO structure declaration(s). The first function declaration was found on line 35; the first OO declaration was found on line 24 (Universal.Files.SeparateFunctionsFromOO.Mixed).

linchpin-bot · 2025-07-18T14:43:35Z

tools/phpstan/constants.php

+
+// Mock Action Scheduler functions.
+if ( ! function_exists( 'as_schedule_single_action' ) ) {
+	function as_schedule_single_action( $timestamp, $hook, $args = [], $group = '' ) {}


🚫 Error: Functions declared in the global namespace by a theme/plugin should start with the theme/plugin prefix. Found: "as_schedule_single_action" (WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedFunctionFound).

linchpin-bot

Previous scan continued.

linchpin-bot · 2025-07-18T14:43:39Z

tools/phpstan/constants.php

+
+// Mock Action Scheduler functions.
+if ( ! function_exists( 'as_schedule_single_action' ) ) {
+	function as_schedule_single_action( $timestamp, $hook, $args = [], $group = '' ) {}


🚫 Error: Missing doc comment for function as_schedule_single_action() (Squiz.Commenting.FunctionComment.Missing).

linchpin-bot · 2025-07-18T14:43:40Z

tools/phpstan/constants.php

+}
+
+if ( ! function_exists( 'as_next_scheduled_action' ) ) {
+	function as_next_scheduled_action( $hook, $args = [], $group = '' ) {}


🚫 Error: Functions declared in the global namespace by a theme/plugin should start with the theme/plugin prefix. Found: "as_next_scheduled_action" (WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedFunctionFound).

linchpin-bot · 2025-07-18T14:43:40Z

tools/phpstan/constants.php

+}
+
+if ( ! function_exists( 'as_next_scheduled_action' ) ) {
+	function as_next_scheduled_action( $hook, $args = [], $group = '' ) {}


🚫 Error: Missing doc comment for function as_next_scheduled_action() (Squiz.Commenting.FunctionComment.Missing).

linchpin-bot · 2025-07-18T14:43:40Z

tools/phpstan/constants.php

+}
+
+if ( ! function_exists( 'as_schedule_recurring_action' ) ) {
+	function as_schedule_recurring_action( $timestamp, $interval_in_seconds, $hook, $args = [], $group = '' ) {}


🚫 Error: Functions declared in the global namespace by a theme/plugin should start with the theme/plugin prefix. Found: "as_schedule_recurring_action" (WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedFunctionFound).

linchpin-bot · 2025-07-18T14:43:40Z

tools/phpstan/constants.php

+}
+
+if ( ! function_exists( 'as_schedule_recurring_action' ) ) {
+	function as_schedule_recurring_action( $timestamp, $interval_in_seconds, $hook, $args = [], $group = '' ) {}


🚫 Error: Missing doc comment for function as_schedule_recurring_action() (Squiz.Commenting.FunctionComment.Missing).

linchpin-bot · 2025-07-18T14:43:40Z

tools/phpstan/constants.php

+
+// Mock WP_CLI\Utils class.
+if ( ! class_exists( 'WP_CLI\Utils' ) ) {
+	class WP_CLI_Utils {


🚫 Error: Only one object structure is allowed in a file (Generic.Files.OneObjectStructurePerFile.MultipleFound).

linchpin-bot · 2025-07-18T14:43:40Z

tools/phpstan/constants.php

+
+// Mock WP_CLI\Utils class.
+if ( ! class_exists( 'WP_CLI\Utils' ) ) {
+	class WP_CLI_Utils {


🚫 Error: Classes declared by a theme/plugin should start with the theme/plugin prefix. Found: "WP_CLI_Utils" (WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedClassFound).

linchpin-bot · 2025-07-18T14:43:40Z

tools/phpstan/constants.php

+
+// Mock WP_CLI\Utils class.
+if ( ! class_exists( 'WP_CLI\Utils' ) ) {
+	class WP_CLI_Utils {


🚫 Error: Missing doc comment for class WP_CLI_Utils (Squiz.Commenting.ClassComment.Missing).

linchpin-bot · 2025-07-18T14:43:40Z

tools/phpstan/constants.php

+// Mock WP_CLI\Utils class.
+if ( ! class_exists( 'WP_CLI\Utils' ) ) {
+	class WP_CLI_Utils {
+		public static function format_items( $format, $items, $fields ) {}


🚫 Error: Missing doc comment for function format_items() (Squiz.Commenting.FunctionComment.Missing).

linchpin-bot · 2025-07-18T14:43:40Z

tools/phpstan/constants.php

+	}
+	// Alias for the namespaced version.
+	class_alias( 'WP_CLI_Utils', 'WP_CLI\Utils' );
+}


🚫 Error: Expected 1 blank line at end of file; 2 found (PSR2.Files.EndFileNewline.TooMany).

aaronware added 2 commits July 17, 2025 10:30

improve(COURIER-1006): Minor Security Hardening

1301651

improve(COURIER-1006): Implement Strauss for dependency prefixing

improve(COURIER-1006): Minor editor adjustments

200ed2b

linchpin-bot requested changes Jul 17, 2025

View reviewed changes

aaronware added 3 commits July 17, 2025 11:48

fix(COURIER-1006): Adjust build process

0c28bd7

improve(COURIER-1006): Husky updates

2dd9d74

chore(COURIER-1006): Adjust build process

84eeb30

feat(COURIER-1006): Implement Prettier feat(COURIER-1006): Add precommit linting feat(COURIER-1006): Add phpstan including baseline

surrealwebs approved these changes Jul 17, 2025

View reviewed changes

aaronware added 4 commits July 17, 2025 19:53

chore(COURIER-1006): Adjusting cleanup rules

edd8c81

improve(COURIER-1006): Update precommit tasks

5af6fd3

chore(COURIER-1006): More pre-commit testing

b35ded3

chore(NO-TASK): Testing pre-commit

8bfb04e

linchpin-bot requested changes Jul 18, 2025

View reviewed changes

aaronware added 2 commits July 18, 2025 10:53

chore(COURIER-1006): Testing pre-commit more

39b179f

chore(NO-TASK): exclude tools from scanning

89e4ee1

aaronware merged commit c1a35ae into main Jul 18, 2025
3 checks passed

Conversation

aaronware commented Jul 17, 2025

Uh oh!

linchpin-bot left a comment

Choose a reason for hiding this comment

Code analysis identified issues

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

linchpin-bot left a comment

Choose a reason for hiding this comment

Code analysis identified issues

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

linchpin-bot left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants