-
Notifications
You must be signed in to change notification settings - Fork 0
Issue/courier 1006 #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Issue/courier 1006 #384
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
1301651
improve(COURIER-1006): Minor Security Hardening
aaronware 200ed2b
improve(COURIER-1006): Minor editor adjustments
aaronware 0c28bd7
fix(COURIER-1006): Adjust build process
aaronware 2dd9d74
improve(COURIER-1006): Husky updates
aaronware 84eeb30
chore(COURIER-1006): Adjust build process
aaronware edd8c81
chore(COURIER-1006): Adjusting cleanup rules
aaronware 5af6fd3
improve(COURIER-1006): Update precommit tasks
aaronware b35ded3
chore(COURIER-1006): More pre-commit testing
aaronware 8bfb04e
chore(NO-TASK): Testing pre-commit
aaronware 39b179f
chore(COURIER-1006): Testing pre-commit more
aaronware 89e4ee1
chore(NO-TASK): exclude tools from scanning
aaronware File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,31 @@ | ||
| # This file is for unifying the coding style for different editors and IDEs | ||
| # editorconfig.org | ||
|
|
||
| # WordPress Coding Standards | ||
| # http://make.wordpress.org/core/handbook/coding-standards/ | ||
|
|
||
| root = true | ||
|
|
||
| [*] | ||
| charset = utf-8 | ||
| end_of_line = lf | ||
| indent_size = 4 | ||
| tab_width = 4 | ||
| indent_style = tab | ||
| indent_size = 2 | ||
| insert_final_newline = true | ||
| trim_trailing_whitespace = true | ||
|
|
||
| [*.{php,js,css,scss}] | ||
| end_of_line = lf | ||
| insert_final_newline = false | ||
| indent_style = tab | ||
| indent_size = 4 | ||
| [*\.txt] | ||
| trim_trailing_whitespace = false | ||
|
|
||
| [*\.{json,yml,yaml,xml,xml\.dist,eslintrc}] | ||
| indent_style = space | ||
| indent_size = 2 | ||
|
|
||
| [*.md] | ||
| indent_style = space | ||
| indent_size = 2 | ||
| trim_trailing_whitespace = false | ||
|
|
||
| [*\.svg] | ||
| insert_final_newline = false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| /build | ||
| /node_modules | ||
| /js |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| /** | ||
| * External dependencies | ||
| */ | ||
| const wpConfig = require('@wordpress/scripts/config/.eslintrc.js'); | ||
|
|
||
| const config = { | ||
| ...wpConfig, | ||
| rules: { | ||
| ...(wpConfig?.rules || {}), | ||
| 'jsdoc/valid-types': 'off', | ||
| 'import/no-unresolved': ['error'], | ||
| }, | ||
| env: { | ||
| browser: true, | ||
| }, | ||
| ignorePatterns: [ | ||
| '/vendor', | ||
| '/node_modules', | ||
| '/build', | ||
| '/dist', | ||
| '/tools', | ||
| '/tests', | ||
| '/**/*.min.js', | ||
| ], | ||
| }; | ||
|
|
||
| module.exports = config; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,3 +24,4 @@ Session.vim | |
| Thumbs.db | ||
| Desktop.ini | ||
| vendor | ||
| vendor-prefixed | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| npx commitlint --edit $1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| # npx lint-staged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {"php":"8.4.5","version":"3.84.0:v3.84.0#38dad0767bf2a9b516b976852200ae722fe984ca","indent":" ","lineEnding":"\n","rules":{"octal_notation":true,"clean_namespace":true,"no_unset_cast":true,"assign_null_coalescing_to_coalesce_equal":true,"normalize_index_brace":true,"short_scalar_cast":true,"heredoc_indentation":true,"no_whitespace_before_comma_in_array":{"after_heredoc":true},"trailing_comma_in_multiline":{"after_heredoc":true},"list_syntax":{"syntax":"short"},"visibility_required":true,"ternary_to_null_coalescing":true,"array_syntax":{"syntax":"short"},"native_constant_invocation":true,"native_function_casing":true,"native_function_invocation":true,"native_type_declaration_casing":true},"hashes":{"includes\/Controller\/Cron.php":"05b3ab71d8472fb9a005d933912d586e"}} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| module.exports = { | ||
| ...require('@wordpress/prettier-config'), | ||
| overrides: [ | ||
| { | ||
| files: ['*.yml', '*.yaml'], | ||
| options: { tabWidth: 2, useTabs: false }, | ||
| }, | ||
| ], | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| { | ||
| ".": "1.7.1" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| { | ||
| "editor.formatOnSave": true, | ||
| "editor.codeActionsOnSave": { | ||
| "source.fixAll": "explicit", | ||
| "source.organizeImports": "explicit" | ||
| }, | ||
| "[php]": { | ||
| "editor.defaultFormatter": "junstyle.php-cs-fixer", | ||
| "editor.formatOnSave": true | ||
| }, | ||
| "[javascript]": { | ||
| "editor.defaultFormatter": "esbenp.prettier-vscode", | ||
| "editor.formatOnSave": true | ||
| }, | ||
| "[typescript]": { | ||
| "editor.defaultFormatter": "esbenp.prettier-vscode", | ||
| "editor.formatOnSave": true | ||
| }, | ||
| "[json]": { | ||
| "editor.defaultFormatter": "esbenp.prettier-vscode", | ||
| "editor.formatOnSave": true | ||
| }, | ||
| "php-cs-fixer.executablePath": "./vendor/bin/php-cs-fixer", | ||
| "php-cs-fixer.config": ".php-cs-fixer.dist.php", | ||
| "php-cs-fixer.onsave": true, | ||
| "php-cs-fixer.autoExecutable": true, | ||
| "prettier.configPath": "package.json" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,13 @@ | ||
| # Frequently Asked Questions # | ||
| # Frequently Asked Questions | ||
|
|
||
| ## Does this plugin work with Full Page Caching or WordPress Object Caching? ## | ||
| ## Does this plugin work with Full Page Caching or WordPress Object Caching? | ||
|
|
||
| Yes | ||
|
|
||
| ## I'm looking for a specific type of notice that courier doesn't have, what's next? ## | ||
| ## I'm looking for a specific type of notice that courier doesn't have, what's next? | ||
|
|
||
| The great thing is that Courier Notices is highly extendable and our team is adding new features constantly since release. You can always create a pull request in GitHub or add an issue. You can also take a look at the Pro version which also has some great features. | ||
|
|
||
| ## Is the compatible with the block editor? | ||
|
|
||
| No but our next release v2.0.0 will be |
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 Error: Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$finder" (WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound).