Fix overriding imports #702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
habara-k
commented
Nov 6, 2024
| } | ||
|
|
||
| model.getVendorExtensions().putIfAbsent("x-py-model-imports", modelsToImport); | ||
| model.getVendorExtensions().put("x-py-model-imports", modelsToImport); |
Contributor
Author
There was a problem hiding this comment.
The method putIfAbsent does nothing because the value is set in AbstractPythonCodegen.java at line 1022, which is called by PythonNextgenCustomClientGenerator.java at line 1085.
Contributor
|
Thank you! Let me approve this change after #704 is merged, and run the new job by fetching the change into this PR. If there is no extra changes(= this change doesn't forget committing some files), it's ok for me. |
Contributor
Yang-33
approved these changes
Nov 7, 2024
habara-k
added a commit
that referenced
this pull request
Nov 19, 2024
This wil be merged after #702. ## Changes As mentioned in #702 (comment), `putIfAbsent` does not overwrite values, so it is meaningless. This change is intended to correct all instances where it is used, although it currently does not affect the generated codes. --------- Co-authored-by: Yuta Kasai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #698.