Skip to content

Fix overriding imports #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Fix overriding imports #702

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4254f0
Fix overriding imports
habara-k Nov 6, 2024
854107d
Add auto-generated codes
habara-k Nov 6, 2024
e9972d5
Merge branch 'master' into fix-overriding-imports
Yang-33 Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion generator/src/main/java/line/bot/generator/PythonNextgenCustomClientGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1368,7 +1368,7 @@ private ModelsMap postProcessModelsMap(ModelsMap objs) {
modelsToImport.add("from " + packageName + ".models." + underscore(modelImport) + " import " + modelImport);
}

model.getVendorExtensions().putIfAbsent("x-py-model-imports", modelsToImport);
model.getVendorExtensions().put("x-py-model-imports", modelsToImport);
Copy link
Contributor Author

@habara-k habara-k Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method putIfAbsent does nothing because the value is set in AbstractPythonCodegen.java at line 1022, which is called by PythonNextgenCustomClientGenerator.java at line 1085.

Copy link
Contributor Author

@habara-k habara-k Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other parts will be fixed in #703.

}
}

Expand Down
1 change: 0 additions & 1 deletion linebot/v3/messaging/models/text_message_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@

from typing import Dict, Optional
from pydantic.v1 import Field, StrictStr
from linebot.v3.messaging.models.dict[str,_substitution_object] import Dict[str, SubstitutionObject]
from linebot.v3.messaging.models.message import Message
from linebot.v3.messaging.models.quick_reply import QuickReply
from linebot.v3.messaging.models.sender import Sender
Expand Down