-
Notifications
You must be signed in to change notification settings - Fork 30
Refine job-level permissions to enhance supply chain security #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
JAVAYou can check generated code in java |
PYTHONYou can check generated code in python |
GOYou can check generated code in go |
PHPYou can check generated code in php |
NODEJSYou can check generated code in nodejs |
| language: python | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Update version in linebot/__about__.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an intentional change. line/line-bot-sdk-python#710 forgot deleting these lines in this repo.
| - name: Setup PHP | ||
| uses: shivammathur/setup-php@9e72090525849c5e82e596468b86eb55e9cc5401 # 2.32.0 | ||
| with: | ||
| distribution: 'temurin' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
distribution: 'temurin' is only for setup-java 😅 some actions may be copied from setup-java, but it's unnecessary.
eucyt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Changes
This PR specifies minimal permissions on each job to reduce unnecessary access to repository contents and avoid potential security risks. By granting only the required scopes (e.g. read-only for repository contents and write access only for issues to post PR comments), we can protect the supply chain from unintended privilege escalations.
parent: line/line-bot-sdk-nodejs#1202