Skip to content

Refine job-level permissions to enhance supply chain security #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 27, 2025
Merged

Refine job-level permissions to enhance supply chain security #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6985adf
NO-ISSUE Grant minimum permission to jobsb
Yang-33 Mar 26, 2025
9fdb21a
NO-ISSUE test
Yang-33 Mar 26, 2025
6e29f70
NO-ISSUE fix
Yang-33 Mar 26, 2025
f253519
NO-ISSUE fix
Yang-33 Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ on:
jobs:
setup:
runs-on: ubuntu-latest

permissions:
contents: read
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- name: Use Node.js
Expand All @@ -24,7 +25,8 @@ jobs:

generate-test:
runs-on: ubuntu-latest

permissions:
contents: read
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- name: Use Node.js
Expand All @@ -44,7 +46,8 @@ jobs:

format-diff:
runs-on: ubuntu-latest

permissions:
contents: read
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- uses: actions/setup-node@cdca7365b2dadb8aad0a33bc7601856ffabcc48e # v4.3.0
Expand Down
30 changes: 17 additions & 13 deletions .github/workflows/sdk-testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ on:
jobs:
test-java:
runs-on: ubuntu-latest

permissions:
contents: read
pull-requests: write
steps:
- name: Checkout SDK repo
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Expand Down Expand Up @@ -52,7 +54,9 @@ jobs:

test-python:
runs-on: ubuntu-latest

permissions:
contents: read
pull-requests: write
steps:
- name: Checkout SDK repo
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Expand All @@ -74,7 +78,6 @@ jobs:
- name: Setup Python
uses: actions/setup-python@8d9ed9ac5c53483de85588cdf95a591a75ab9f55 # v5.5.0
with:
distribution: 'temurin'
python-version: '3.11'

- name: Install dependencies
Expand All @@ -96,16 +99,14 @@ jobs:
language: python
github-token: ${{ secrets.GITHUB_TOKEN }}

- name: Update version in linebot/__about__.py
Copy link
Contributor Author

@Yang-33 Yang-33 Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an intentional change. line/line-bot-sdk-python#710 forgot deleting these lines in this repo.

run: |
sed -i "s/__version__ = '__LINE_BOT_SDK_PYTHON_VERSION__'/__version__ = '12.34.5'/g" linebot/__about__.py

- name: Test with pytest
run: tox

test-php:
runs-on: ubuntu-latest

permissions:
contents: read
pull-requests: write
steps:
- name: Checkout SDK repo
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Expand All @@ -127,7 +128,6 @@ jobs:
- name: Setup PHP
uses: shivammathur/setup-php@9e72090525849c5e82e596468b86eb55e9cc5401 # 2.32.0
with:
distribution: 'temurin'
Copy link
Contributor Author

@Yang-33 Yang-33 Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

distribution: 'temurin' is only for setup-java 😅 some actions may be copied from setup-java, but it's unnecessary.

php-version: '8.2'

- name: Install openapi-generator-cli
Expand Down Expand Up @@ -183,7 +183,9 @@ jobs:

test-nodejs:
runs-on: ubuntu-latest

permissions:
contents: read
pull-requests: write
steps:
- name: Checkout SDK repo
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Expand All @@ -202,7 +204,7 @@ jobs:
PR_REF: ${{ github.event.pull_request.head.ref }}

# https://github.com/line/line-bot-sdk-nodejs/blob/master/.github/workflows/test.yml
- name: actions/setup-java@v3
- name: Setup Java
uses: actions/setup-java@3a4f6e1af504cf6a31855fa899c6aa5355ba6c12 # v4.7.0
with:
distribution: 'temurin'
Expand Down Expand Up @@ -236,7 +238,9 @@ jobs:

test-go:
runs-on: ubuntu-latest

permissions:
contents: read
pull-requests: write
steps:
- name: Checkout SDK repo
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Expand All @@ -255,7 +259,7 @@ jobs:
PR_REF: ${{ github.event.pull_request.head.ref }}

# https://github.com/line/line-bot-sdk-go/blob/master/.github/workflows/go.yml
- name: actions/setup-java@v3
- name: Setup Java
uses: actions/setup-java@3a4f6e1af504cf6a31855fa899c6aa5355ba6c12 # v4.7.0
with:
distribution: 'temurin'
Expand Down