Fix typo and variable names #3649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 25, 2025
Closed
Contributor
Author
ndr-ds
requested review from
MathieuDutSik,
Twey,
afck,
christos-h,
jvff and
ma2bd
ma2bd
approved these changes
Mar 25, 2025
ndr-ds
force-pushed
the
03-25-support_default_namespace_on_rocksdb
branch
from
99f0d12 to
36bb92d
Compare
ndr-ds
force-pushed
the
03-25-fix_typo_and_variable_names
branch
from
c6649c1 to
23891bb
Compare
afck
approved these changes
Mar 26, 2025
| /// Already existing storage | ||
| #[error("Already existing storag")] | ||
| #[error("Already existing storage")] | ||
| StoreAlreadyExist, |
Contributor
There was a problem hiding this comment.
(This should probably be StoreAlreadyExists or StorageAlreadyExists.)
Contributor
There was a problem hiding this comment.
And "store already exists" :)
ndr-ds
force-pushed
the
03-25-fix_typo_and_variable_names
branch
from
23891bb to
ad0ee2f
Compare
ndr-ds
force-pushed
the
03-25-support_default_namespace_on_rocksdb
branch
from
36bb92d to
ad37184
Compare
Contributor
Author
ndr-ds
force-pushed
the
03-25-fix_typo_and_variable_names
branch
from
ad0ee2f to
d8c1a8d
Compare
ndr-ds
force-pushed
the
03-25-support_default_namespace_on_rocksdb
branch
from
ad37184 to
ab5f782
Compare
ndr-ds
changed the base branch from
03-25-support_default_namespace_on_rocksdb
to
graphite-base/3649
ndr-ds
force-pushed
the
03-25-fix_typo_and_variable_names
branch
from
d8c1a8d to
b0f56bb
Compare
This was referenced Mar 26, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There was a small typo in one of the error enums, and also some variable names that sounded confusing to me
Proposal
Fix typo and improve variable names a bit
Test Plan
CI
Release Plan